From 324c57ede17800b142cb4bcc0a84a76f2dbff06b Mon Sep 17 00:00:00 2001
From: "Jakaraddi, Manjunath" <Manjunath.Jakaraddi@amd.com>
Date: Thu, 16 Jan 2025 02:14:22 -0800
Subject: [PATCH] SWDEV-500520: Updated documentation for hang issue (#79)

* SWDEV-500520: Updated documentation for hang issue

* Avoid fatal error when invalid metric is found

* removing invalid metrics

* clang formatting

[ROCm/rocprofiler-sdk commit: dfee6489b1aa38352aab48245575796236f2a1ab]
---
 .../source/docs/how-to/using-rocprofv3.rst    | 19 +++++++++----------
 .../source/lib/rocprofiler-sdk-tool/tool.cpp  |  6 +++---
 2 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3.rst b/projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3.rst
index 2490ceffc2..34a875a34f 100644
--- a/projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3.rst
+++ b/projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3.rst
@@ -789,22 +789,23 @@ Properties
     $ cat input.json
 
     {
-        "jobs": [
-        {
+      "jobs": [
+         {
             "pmc": ["SQ_WAVES", "GRBM_COUNT", "GRBM_GUI_ACTIVE"]
-        },
-        {
+         },
+         {
             "pmc": ["FETCH_SIZE", "WRITE_SIZE"],
             "kernel_include_regex": ".*_kernel",
             "kernel_exclude_regex": "multiply",
-            "kernel_iteration_range": "[1-2]","[3-4]"
+            "kernel_iteration_range": "[1-2],[3-4]",
             "output_file": "out",
             "output_format": [
-                    "csv",
-                    "json"
+               "csv",
+               "json"
             ],
             "truncate_kernels": true
-        ]
+         }
+      ]
     }
 
 .. code-block:: shell
@@ -816,8 +817,6 @@ Properties
         - SQ_WAVES
         - GRBM_COUNT
         - GRBM_GUI_ACTIVE
-        - 'TCC_HIT[1]'
-        - 'TCC_HIT[2]'
     - pmc:
         - FETCH_SIZE
         - WRITE_SIZE
diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp
index 1b85adce4c..d19c55217e 100644
--- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp
+++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp
@@ -838,9 +838,9 @@ get_device_counting_service(rocprofiler_agent_id_t agent_id)
                                                                 ", "));
                 auto found_counters =
                     fmt::format("{}", fmt::join(found_v.begin(), found_v.end(), ", "));
-                LOG(FATAL) << "Unable to find all counters for agent " << agent_v->node_id
-                           << " (gpu-" << agent_v->gpu_index << ", " << agent_v->name << ") in ["
-                           << requested_counters << "]. Found: [" << found_counters << "]";
+                ROCP_WARNING << "Unable to find all counters for agent " << agent_v->node_id
+                             << " (gpu-" << agent_v->gpu_index << ", " << agent_v->name << ") in ["
+                             << requested_counters << "]. Found: [" << found_counters << "]";
             }
 
             if(!counters_v.empty())