AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve buffer flush error handling (#416)

Browse Source 
* Update include/rocprofiler-sdk/fwd.h

- add ROCPROFILER_STATUS_ERROR_FINALIZED error code

* Update lib/rocprofiler-sdk/rocprofiler.cpp

- status string for ROCPROFILER_STATUS_ERROR_FINALIZED

* Update lib/rocprofiler-sdk/buffer.cpp

- return error code if buffer flush invoked after finalized
- fatal error if task group destroyed
- error message if task runs after finalized
- improve join of task group

* Update lib/rocprofiler-sdk/counters/tests/evaluate_ast_tests.cpp

- Update lambdas to return reference due to strange -Warray-bounds and -Wstringop-overflow warnings with g++ (Ubuntu 13.1.0-8ubuntu1~20.04.2) 13.1.0
This commit is contained in:
Jonathan R. Madsen
2024-01-26 04:01:09 -06:00
committed by GitHub
parent c443663032
commit 3547a45c0c
4 changed files with 33 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/lib/rocprofiler-sdk/counters/tests/evaluate_ast_test.cpp
+10 -5
View File
@@ -591,7 +591,8 @@ TEST(evaluate_ast, counter_reduction_sum)
return base_id;
};
auto sum_vec = [](auto& a) {
auto sum_vec = [](auto& a) -> auto&
{
for(size_t i = 1; i < a.size(); i++)
{
a[0].counter_value += a[i].counter_value;
@@ -671,7 +672,8 @@ TEST(evaluate_ast, counter_reduction_min)
return base_id;
};
auto min_vec = [](auto& a) {
auto min_vec = [](auto& a) -> auto&
{
a[0].counter_value = std::min_element(a.begin(), a.end(), [](const auto& b, const auto& c) {
return b.counter_value < c.counter_value;
})->counter_value;
@@ -750,7 +752,8 @@ TEST(evaluate_ast, counter_reduction_max)
return base_id;
};
auto max_vec = [](auto& a) {
auto max_vec = [](auto& a) -> auto&
{
a[0].counter_value = std::max_element(a.begin(), a.end(), [](const auto& b, const auto& c) {
return b.counter_value < c.counter_value;
})->counter_value;
@@ -829,7 +832,8 @@ TEST(evaluate_ast, counter_reduction_avg)
return base_id;
};
auto avg_vec = [](auto& a) {
auto avg_vec = [](auto& a) -> auto&
{
for(size_t i = 1; i < a.size(); i++)
{
a[0].counter_value += a[i].counter_value;
@@ -910,7 +914,8 @@ TEST(evaluate_ast, evaluate_mixed_counters)
return base_id;
};
auto sum_vec = [](auto& a) {
auto sum_vec = [](auto& a) -> auto&
{
for(size_t i = 1; i < a.size(); i++)
{
a[0].counter_value += a[i].counter_value;