AI/rocm-systems
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

P4 to Git Change 1532400 by emankov@em-hsa on 2018/03/26 13:44:26

Browse Source 
SWDEV-143465 - Stop building static C++ kernels on CI+

	Changed legacy HSAIL/AMDIL stack logic:
	    1. Stop supporting AMDIL on CI+ devices: "AMDIL doesn't support device ..." will be reported.
	    2. Stop handling OpenCL extension options in RT: if "-x spir" or "-x clc++" option is specified, it wouldn't force legacy AMDIL compiler anymore.
	    3. Start reporting error on "-legacy" option in HSAIL compiler. If we reach HSAIL compiler, then it means that there are conflicting options. Report them all, possible options are: -frontend=edg, -cl-std=CL2.0 (>= 2.0), -binary_is_spirv.

	Already submitted changes in stack logic:
	    1. Start reporting error for SI devices on HSAIL path.
	    2. Start handling OpenCL extension options on HSAIL path: report error on "-x spir" or "-x clc++" options.

	[testing] http://ocltc.amd.com:8111/viewModification.html?modId=99901&personal=true&tab=vcsModificationBuilds

	[reviewed] by Stas and German: http://ocltc.amd.com/reviews/r/14270

Affected files ...

... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/backends/common/v0_8/if_acl.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#99 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#586 edit
This commit is contained in:
foreman committed 2018-03-26 13:50:18 -04:00
1 parent 0caa7e4cc1
commit 3876272309
2 files changed
+37 -13
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

rocclr/runtime/device/gpu/gpudevice.cpp
+1 -6
View File
@@ -243,7 +243,6 @@ bool NullDevice::isHsailProgram(amd::option::Options* options) {
bool isHSAILcapable = settings().hsail_;
bool isBlit = false;
bool isSPIRV = false;
bool isLangExt = false;
bool isClang = false;
bool isEDG = false;
bool isLegacy = false;
@@ -271,10 +270,6 @@ bool NullDevice::isHsailProgram(amd::option::Options* options) {
if (!isLegacy) {
isLegacy = op->oVariables->Legacy;
}
if (!isLangExt) {
isLangExt = op->isCStrOptionsEqual(op->oVariables->XLang, "clc++") ||
op->isCStrOptionsEqual(op->oVariables->XLang, "spir");
}
// Checks Frontend option only from input *options, not from Env,
// because they might be only calculated by RT based on the binaries to link.
// -frontend is being queried now instead of -cl-std=CL2.0, because the last one
@@ -297,7 +292,7 @@ bool NullDevice::isHsailProgram(amd::option::Options* options) {
if (isSPIRV || (isBlit && isCIPlus && isHSAILcapable) || isClang || isOCL20) {
return true;
}
if (isLegacy || !isHSAILcapable || isEDG || isLangExt) {
if (isLegacy || !isHSAILcapable || isEDG) {
return false;
}
return true;