From 39211c6b41bdbe68ff438db0b18dce9787c61200 Mon Sep 17 00:00:00 2001 From: Bertan Dogancay <111835151+BertanDogancay@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:26:53 -0400 Subject: [PATCH] [NPKit] Use default output directory when env var is not set (#1747) --- src/init.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/init.cc b/src/init.cc index 8f3884fa1b..6028566014 100644 --- a/src/init.cc +++ b/src/init.cc @@ -2558,10 +2558,17 @@ static ncclResult_t commCleanup(ncclComm_t comm) { // Dump NPKit events and shutdown const char* npkitDumpDir = getenv("NPKIT_DUMP_DIR"); if (npkitDumpDir == nullptr) { - WARN("NPKIT_DUMP_DIR is empty"); - } else { - NCCLCHECK(NpKit::Dump(npkitDumpDir)); + npkitDumpDir = "./npkit_dump"; + INFO(NCCL_INIT, "NPKIT_DUMP_DIR is not set, using default directory: %s", npkitDumpDir); + + struct stat st; + if (stat(npkitDumpDir, &st) != 0) { + if (mkdir(npkitDumpDir, 0755) != 0) { + WARN("Failed to create NPKIT_DUMP_DIR directory: %s", npkitDumpDir); + } + } } + NCCLCHECK(NpKit::Dump(npkitDumpDir)); NCCLCHECK(NpKit::Shutdown()); #endif