build: slightly change files to pass compilation

Compiled using Clang and encountered errors on ambiguous pointer
type, implicit conversion NULL to bool, and unused function, etc.
As a fix, this patch slightly updates the related codes.

Change-Id: I4a73d66293313dda36749036f5c73aaf2a445231


[ROCm/rocprofiler commit: ee917344ff]

projects/rocprofiler/src/core/tracker.h

@@ -83,7 +83,7 @@ class Tracker {
 
   static void Destroy() {
     std::lock_guard<mutex_t> lck(glob_mutex_);
-    if (instance_ != NULL) delete instance_;
+    if (instance_ != NULL) delete instance_.load();
     instance_ = NULL;
   }
 

projects/rocprofiler/src/util/hsa_rsrc_factory.h

@@ -226,7 +226,7 @@ class HsaRsrcFactory {
 
   static void Destroy() {
     std::lock_guard<mutex_t> lck(mutex_);
-    if (instance_) delete instance_;
+    if (instance_) delete instance_.load();
     instance_ = NULL;
   }
 

projects/rocprofiler/src/util/logger.h

@@ -90,7 +90,7 @@ class Logger {
 
   static void Destroy() {
     std::lock_guard<mutex_t> lck(mutex_);
-    if (instance_ != NULL) delete instance_;
+    if (instance_ != NULL) delete instance_.load();
     instance_ = NULL;
   }