AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CI timeout + line-info in releases (#279)

Browse Source 
* Update perfetto args.gn.in

- remove enable_perfetto_tools_trace_to_text (unused)

* core timeout implementation

- requires OMNITRACE_CI=ON
- requires OMNITRACE_CI_TIMEOUT=<sec>
- adds pthread_self and std::this_thread::get_id to thread info
- pthread_create_gotcha stores native handles (pthread_self)

* Testing updates

- improve detection of segfault/failures with PASS_REGEX exists
- add OMNITRACE_CI_TIMEOUT env variable to all tests

* Line-info in releases

- e.g. -g1 + more options to minimize size of debug info

* Fix typo in config exit action message

* OMNITRACE_UNLIKELY around debug/verbose messages

* format fixes

* Overflow tests + capability check

* transpose example update

- link to threads library

* roctracer/rocprofiler update

- in ROCm 5.5.0, cannot include rocprofiler.h and roctracer.h in same file due to conflicting enum defs
- Moved HSA tracing setup/shutdown to component::roctracer

* roctracer update

- fix definition of roctracer::setup when disabled

* Update fork example

- detach threads on main PID
- flush io outputs when printing info

* Update overflow tests

- pass regular expressions
- overflow on PERF_COUNT_SW_CPU_CLOCK event

* fork gotcha update

- use getpid() instead of getppid()

* update fork example

- wait on threads calling fork

* timeout update

- wait on timeout thread to launch before proceeding
This commit is contained in:
Jonathan R. Madsen
2023-06-14 11:55:22 -05:00
committed by GitHub
parent 9de3a6b0b4
commit 3e2fa69a14
36 changed files with 1234 additions and 311 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/lib/omnitrace/library/thread_info.cpp
+75 -10
View File
@@ -75,21 +75,31 @@ init_index_data(int64_t _tid, bool _offset = false)
if(!itr)
{
threading::offset_this_id(_offset);
itr = thread_index_data{};
itr = thread_index_data{};
OMNITRACE_CONDITIONAL_THROW(itr->internal_value != _tid,
"Error! thread_info::init_index_data was called for "
"thread %zi on thread %zi\n",
_tid, itr->internal_value);
int _verb = 2;
// if thread created using finalization, bump up the minimum verbosity level
if(get_state() >= State::Finalized && _offset) _verb += 2;
if(!config::settings_are_configured())
{
OMNITRACE_BASIC_VERBOSE_F(
_verb, "Thread %li on PID %i (rank: %i) assigned omnitrace TID %li\n",
itr->system_value, process::get_id(), dmp::rank(), itr->sequent_value);
OMNITRACE_BASIC_VERBOSE_F(_verb,
"Thread %li on PID %i (rank: %i) assigned "
"omnitrace TID %li (internal: %li)\n",
itr->system_value, process::get_id(), dmp::rank(),
itr->sequent_value, itr->internal_value);
}
else
{
OMNITRACE_VERBOSE_F(
_verb, "Thread %li on PID %i (rank: %i) assigned omnitrace TID %li\n",
itr->system_value, process::get_id(), dmp::rank(), itr->sequent_value);
OMNITRACE_VERBOSE_F(_verb,
"Thread %li on PID %i (rank: %i) assigned omnitrace TID "
"%li (internal: %li)\n",
itr->system_value, process::get_id(), dmp::rank(),
itr->sequent_value, itr->internal_value);
}
}
return itr;
@@ -191,6 +201,46 @@ thread_info::get()
return get_info_data(utility::get_thread_index());
}
const std::optional<thread_info>&
thread_info::get(native_handle_t& _tid)
{
return get(native_handle_t{ _tid });
}
const std::optional<thread_info>&
thread_info::get(native_handle_t&& _tid)
{
const auto& _v = get_info_data();
if(_v)
{
for(const auto& itr : *_v)
{
if(itr && itr->index_data &&
pthread_equal(itr->index_data->pthread_value, _tid) == 0)
return itr;
}
}
OMNITRACE_CI_THROW(unknown_thread, "Unknown thread has been assigned a value");
return unknown_thread;
}
const std::optional<thread_info>&
thread_info::get(std::thread::id _tid)
{
const auto& _v = get_info_data();
if(_v)
{
for(const auto& itr : *_v)
{
if(itr && itr->index_data && itr->index_data->stl_value == _tid) return itr;
}
}
OMNITRACE_CI_THROW(unknown_thread, "Unknown thread has been assigned a value");
return unknown_thread;
}
const std::optional<thread_info>&
thread_info::get(int64_t _tid, ThreadIdType _type)
{
@@ -203,7 +253,8 @@ thread_info::get(int64_t _tid, ThreadIdType _type)
{
for(const auto& itr : *_v)
{
if(itr && itr->index_data->system_value == _tid) return itr;
if(itr && itr->index_data && itr->index_data->system_value == _tid)
return itr;
}
}
}
@@ -214,10 +265,21 @@ thread_info::get(int64_t _tid, ThreadIdType _type)
{
for(const auto& itr : *_v)
{
if(itr && itr->index_data->sequent_value == _tid) return itr;
if(itr && itr->index_data && itr->index_data->sequent_value == _tid)
return itr;
}
}
}
else if(_type == ThreadIdType::PthreadID)
{
OMNITRACE_THROW("omnitrace does not support thread_info::get(int64_t, "
"ThreadIdType) with ThreadIdType::PthreadID\n");
}
else if(_type == ThreadIdType::StlThreadID)
{
OMNITRACE_THROW("omnitrace does not support thread_info::get(int64_t, "
"ThreadIdType) with ThreadIdType::StlThreadID\n");
}
OMNITRACE_CI_THROW(unknown_thread, "Unknown thread has been assigned a value");
return unknown_thread;
@@ -302,8 +364,11 @@ thread_info::as_string() const
std::stringstream _ss{};
_ss << std::boolalpha << "is_offset=" << is_offset;
if(index_data)
{
_ss << ", index_data=(" << index_data->internal_value << ", "
<< index_data->system_value << ", " << index_data->sequent_value << ")";
<< index_data->system_value << ", " << index_data->sequent_value << ", "
<< index_data->pthread_value << ", " << index_data->stl_value << ")";
}
if(causal_count) _ss << ", causal count=" << *causal_count;
_ss << ", lifetime=(" << lifetime.first << ":" << lifetime.second << ")";
return _ss.str();