Add support for AQL dimensions (#262)
* Add support for AQL dimension changes Adds support for returning dimensions from AQLProfile through rocprofiler to tools. Includes a much larger expanded test suite that covers nearly all files in counter collection. Specific changes below: samples/counter_collection/print_functional_counters: Modified to check the validity of dimensions returned in comparison to the actual underlying data obtained from a kernel execution. rocprofiler-sdk/aql/helpers: adds function calls to support fetching dimension information from AQLProfile. rocprofiler-sdk/aql/packet_construct: modified to allow for events to be exported to aid evaluate_ast in decoding the output buffer. lib/rocprofiler-sdk/counters: Instance count now derived from dimension sizes. rocprofiler_query_counter_dimensions now moved to a callback format to improve usability. rocprofiler-sdk/counters/core: Code migrations and exports of functions for testing. rocprofiler-sdk/counters/dimensions: Generates a dimension cache to be used when querying dimension information for a counter id. rocprofiler-sdk/counters/evaluate_ast: Modified to pass back correct dimension information and to check/determine output dimensions for derived counters. rocprofiler-sdk/counters/id_decode: Modified to have a map between dimension name -> dimension along with a conversion from the aql profile id for a dimension (string) -> integer based id (happens only once during init). rocprofiler-sdk/hsa/queue: Modified to allow for making testing easier. Specifically to allow Queue to now be mocked in unit tests for counter collection. * Merge with changes for serialization * Added suggestions * source formatting (clang-format v11) (#457) Co-authored-by: bwelton <bwelton@users.noreply.github.com> * Minor fix * Test change --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: bwelton <bwelton@users.noreply.github.com>
이 커밋은 다음에 포함됨:
@@ -269,6 +269,12 @@ QueueController::profiler_serializer(FuncT&& lambda)
|
||||
_profiler_serializer.wlock(std::forward<FuncT>(lambda));
|
||||
}
|
||||
|
||||
void
|
||||
QueueController::disable_serialization()
|
||||
{
|
||||
profiler_serializer([](auto& serializer) { serializer.enabled = false; });
|
||||
}
|
||||
|
||||
namespace
|
||||
{
|
||||
/*
|
||||
@@ -291,6 +297,7 @@ profiler_serializer_ready_signal_handler(hsa_signal_value_t /* signal_value */,
|
||||
auto* hsa_queue = static_cast<hsa_queue_t*>(data);
|
||||
const auto* queue = get_queue_controller().get_queue(*hsa_queue);
|
||||
get_queue_controller().profiler_serializer([&](auto& serializer) {
|
||||
if(!serializer.enabled) return;
|
||||
{
|
||||
std::lock_guard<std::mutex> cv_lock(queue->cv_mutex);
|
||||
if(queue->get_state() == queue_state::to_destroy)
|
||||
@@ -322,6 +329,7 @@ void
|
||||
profiler_serializer_kernel_completion_signal(hsa_signal_t queue_block_signal)
|
||||
{
|
||||
get_queue_controller().profiler_serializer([queue_block_signal](auto& serializer) {
|
||||
if(!serializer.enabled) return;
|
||||
assert(serializer.dispatch_queue != nullptr);
|
||||
serializer.dispatch_queue = nullptr;
|
||||
get_queue_controller().get_core_table().hsa_signal_store_screlease_fn(queue_block_signal,
|
||||
@@ -370,6 +378,17 @@ QueueController::iterate_queues(const queue_iterator_cb_t& cb) const
|
||||
});
|
||||
}
|
||||
|
||||
void
|
||||
QueueController::iterate_callbacks(const callback_iterator_cb_t& cb) const
|
||||
{
|
||||
_callback_cache.rlock([&cb](const auto& map) {
|
||||
for(const auto& [cid, tuple] : map)
|
||||
{
|
||||
cb(cid, tuple);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
QueueController&
|
||||
get_queue_controller()
|
||||
{
|
||||
|
||||
새 이슈에서 참조
사용자 차단