From 3fb1496fb3a03c9a4ee040c09b8044c77a1237a9 Mon Sep 17 00:00:00 2001 From: Graham Sider Date: Thu, 26 Jan 2023 15:01:24 -0500 Subject: [PATCH] kfdtest: Remove redundant SGPR/VGPR size checks in KFDTopologyTest KFDTopologyTest.BasicTest duplicates Thunk logic to calculate VGPR size, meaning it will always be the same, and SGPR size is a constant. Since no benefit, remove comparisons. Signed-off-by: Graham Sider Change-Id: I99e7ff6fb69ed07bc0716fdf43946b19c67b9268 --- tests/kfdtest/src/KFDTopologyTest.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/kfdtest/src/KFDTopologyTest.cpp b/tests/kfdtest/src/KFDTopologyTest.cpp index b4b406a24a..b4c2ebfca6 100644 --- a/tests/kfdtest/src/KFDTopologyTest.cpp +++ b/tests/kfdtest/src/KFDTopologyTest.cpp @@ -59,11 +59,7 @@ TEST_F(KFDTopologyTest , BasicTest) { EXPECT_GE(pNodeProperties->EngineId.ui32.Major, 7) << "Major Version is less than 7"; EXPECT_LT(pNodeProperties->EngineId.ui32.Minor, 10) << "Minor Version is greater than 9"; EXPECT_GT(pNodeProperties->uCodeEngineVersions.uCodeSDMA, 0) << "sDMA firmware version is 0"; - HSAuint32 VGPRSize = (FamilyIdFromNode(pNodeProperties) == FAMILY_AR || - FamilyIdFromNode(pNodeProperties) == FAMILY_AL) ? - 0x80000 : 0x40000; - EXPECT_EQ(pNodeProperties->VGPRSizePerCU, VGPRSize) << "VGPR Size Per CU is not correct"; - EXPECT_EQ(pNodeProperties->SGPRSizePerCU, 0x4000) << "SGPR Size Per CU is not correct"; + LOG() << "VGPR Size is " << pNodeProperties->VGPRSizePerCU << " SGPR Size is " << pNodeProperties->SGPRSizePerCU << std::endl; }