Store target ID in isa registry

Store target ID string in isa registry and use for returning agent and
isa name.

Change-Id: I72a20d8ff963c73d86392158aff3853e4c9bfdbd


[ROCm/ROCR-Runtime commit: 853ccc762e]

projects/rocr-runtime/runtime/hsa-runtime/core/inc/isa.h

@@ -2,24 +2,24 @@
 //
 // The University of Illinois/NCSA
 // Open Source License (NCSA)
-// 
+//
 // Copyright (c) 2014-2020, Advanced Micro Devices, Inc. All rights reserved.
-// 
+//
 // Developed by:
-// 
+//
 //                 AMD Research and AMD HSA Software Development
-// 
+//
 //                 Advanced Micro Devices, Inc.
-// 
+//
 //                 www.amd.com
-// 
+//
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to
 // deal with the Software without restriction, including without limitation
 // the rights to use, copy, modify, merge, publish, distribute, sublicense,
 // and/or sell copies of the Software, and to permit persons to whom the
 // Software is furnished to do so, subject to the following conditions:
-// 
+//
 //  - Redistributions of source code must retain the above copyright notice,
 //    this list of conditions and the following disclaimers.
 //  - Redistributions in binary form must reproduce the above copyright
@@ -29,7 +29,7 @@
 //    nor the names of its contributors may be used to endorse or promote
 //    products derived from this Software without specific prior written
 //    permission.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
@@ -178,7 +178,10 @@ class Isa final: public amd::hsa::common::Signed<0xB13594F2BD8F212D> {
     return true;
   }
 
-  /// @returns This Isa's full name.
+  /// @returns This Isa's processor name.
+  std::string GetName() const;
+
+  /// @returns This Isa's full target triple and target ID name.
   std::string GetFullName() const;
 
   /// @brief Query value of requested @p attribute and record it in @p value.
@@ -194,23 +197,13 @@ class Isa final: public amd::hsa::common::Signed<0xB13594F2BD8F212D> {
  private:
   /// @brief Default constructor.
   Isa()
-      : version_(Version(-1, -1, -1)),
+      : targetid_(nullptr),
+        version_(Version(-1, -1, -1)),
         sramecc_(IsaFeature::Unsupported),
         xnack_(IsaFeature::Unsupported) {}
 
-  /// @brief Construct from @p version.
-  Isa(const Version &version)
-      : version_(version),
-        sramecc_(IsaFeature::Unsupported),
-        xnack_(IsaFeature::Unsupported) {}
-
-  /// @brief Construct from @p version.
-  Isa(const Version &version,
-      IsaFeature sramecc,
-      IsaFeature xnack)
-      : version_(version),
-        sramecc_(sramecc),
-        xnack_(xnack) {}
+  // @brief Isa's target ID name.
+  const char* targetid_;
 
   /// @brief Isa's version.
   Version version_;