From 3fe891d5dabdfe523a15a9c0dceaa67787bd2c16 Mon Sep 17 00:00:00 2001 From: Sean Keely Date: Wed, 8 Apr 2020 15:07:42 -0500 Subject: [PATCH] Suppress Finalizer loading attempts. This has been the default mode for a while now since we don't distribute or build the finalizer. Removing the attempt cleans up debug mode messages that are causing confusion. Change-Id: I8162c95abd5bbedaa22b90191f7a384a34c388ae --- runtime/hsa-runtime/core/runtime/runtime.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/runtime/hsa-runtime/core/runtime/runtime.cpp b/runtime/hsa-runtime/core/runtime/runtime.cpp index e2f7b0e5bd..612e5ad876 100644 --- a/runtime/hsa-runtime/core/runtime/runtime.cpp +++ b/runtime/hsa-runtime/core/runtime/runtime.cpp @@ -1348,12 +1348,14 @@ void Runtime::LoadExtensions() { "libhsa-ext-image.so.1"}; #endif - // Update Hsa Api Table with handle of Image extension Apis - extensions_.LoadFinalizer(kFinalizerLib[os_index(os::current_os)]); + // Update Hsa Api Table with handle of Finalizer extension Apis + // Skipping finalizer loading since finalizer is no longer distributed. + // LinkExts will expose the finalizer-not-present implementation. + // extensions_.LoadFinalizer(kFinalizerLib[os_index(os::current_os)]); hsa_api_table_.LinkExts(&extensions_.finalizer_api, core::HsaApiTable::HSA_EXT_FINALIZER_API_TABLE_ID); - // Update Hsa Api Table with handle of Finalizer extension Apis + // Update Hsa Api Table with handle of Image extension Apis extensions_.LoadImage(kImageLib[os_index(os::current_os)]); hsa_api_table_.LinkExts(&extensions_.image_api, core::HsaApiTable::HSA_EXT_IMAGE_API_TABLE_ID);