SWDEV-486602 - Add tracking of HSA handlers

Add an atomic counter to track the outstanding HSA handlers.
Wait on CPU for the callbacks if the number exceeds the value
in DEBUG_HIP_BLOCK_SYNC env variable.

Change-Id: I95dc8c4bf0258c7e59411b7504220709ed6898c5
This commit is contained in:
German Andryeyev
2024-10-23 16:15:46 -04:00
bovenliggende 556390f9c7
commit 403f624bf8
4 gewijzigde bestanden met toevoegingen van 17 en 9 verwijderingen
+4
Bestand weergeven
@@ -1332,6 +1332,9 @@ class VirtualDevice : public amd::HeapObject {
const std::string& kernelName,
amd::AccumulateCommand* vcmd = nullptr) = 0;
//! Returns the number of outstanding HSA async handlers
std::atomic<uint64_t>& QueuedAsyncHandlers() const { return queued_async_handlers_; }
private:
//! Disable default copy constructor
VirtualDevice& operator=(const VirtualDevice&);
@@ -1347,6 +1350,7 @@ class VirtualDevice : public amd::HeapObject {
amd::Monitor execution_; //!< Lock to serialise access to all device objects
uint index_; //!< The virtual device unique index
mutable std::atomic<uint64_t> queued_async_handlers_ = 0; //!< Outstanding HSA async handlers
};
} // namespace amd::device
+6 -2
Bestand weergeven
@@ -232,11 +232,14 @@ bool HsaAmdSignalHandler(hsa_signal_value_t value, void* arg) {
// Save callback signal
hsa_signal_t callback_signal = ts->GetCallbackSignal();
auto gpu = ts->gpu();
gpu->QueuedAsyncHandlers()--;
// Reset last used SDMA engine mask
ts->gpu()->setLastUsedSdmaEngine(0);
gpu->setLastUsedSdmaEngine(0);
// Update the batch, since signal is complete
ts->gpu()->updateCommandsState(ts->command().GetBatchHead());
gpu->updateCommandsState(ts->command().GetBatchHead());
// Reset API callback signal. It will release AQL queue and start commands processing
if (callback_signal.handle != 0) {
@@ -474,6 +477,7 @@ hsa_signal_t VirtualGPU::HwQueueTracker::ActiveSignal(
hsa_signal_add_relaxed(prof_signal->signal_, 1);
init_value += 1;
}
gpu_.QueuedAsyncHandlers()++;
hsa_status_t result = hsa_amd_signal_async_handler(prof_signal->signal_,
HSA_SIGNAL_CONDITION_LT, init_value, &HsaAmdSignalHandler, ts);
if (HSA_STATUS_SUCCESS != result) {