AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not allow GPU as intermediate

Browse Source 
[ROCm/rccl commit: 105db19a11]
This commit is contained in:
Wenkai Du
2020-12-08 17:35:07 -05:00
parent 34c6013299
commit 41bead5a4e
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rccl/src/graph/paths.cc
+7 -4
View File
@@ -87,14 +87,17 @@ static ncclResult_t ncclTopoSetPaths(struct ncclTopoNode* baseNode, struct ncclT
// Consider a path going through the CPU as PATH_PHB // Consider a path going through the CPU as PATH_PHB
if (link->type == LINK_PCI && (node->type == CPU || link->remNode->type == CPU)) type = PATH_PHB; if (link->type == LINK_PCI && (node->type == CPU || link->remNode->type == CPU)) type = PATH_PHB;
// Set 1 hop NVLink as NVB // Set 1 hop NVLink as NVB
if (node->type == GPU && path->type == PATH_NVL && type == PATH_NVL && remPath->count > 1) type = PATH_NVB; //if (node->type == GPU && path->type == PATH_NVL && type == PATH_NVL && remPath->count > 1) type = PATH_NVB;
remPath->type = std::max(path->type, type); remPath->type = std::max(path->type, type);
// Add to the list for the next iteration if not already in the list // Add to the list for the next iteration if not already in the list
int i; // Disallow GPUs as intermediate steps for now
for (i=0; i<nextNodeList.count; i++) if (nextNodeList.list[i] == remNode) break; if (remNode->type != GPU) {
if (i == nextNodeList.count) nextNodeList.list[nextNodeList.count++] = remNode; int i;
for (i=0; i<nextNodeList.count; i++) if (nextNodeList.list[i] == remNode) break;
if (i == nextNodeList.count) nextNodeList.list[nextNodeList.count++] = remNode;
}
} }
} }
} }