From 4588da1888f7a35a8a5ba86c67a806728540c2ce Mon Sep 17 00:00:00 2001 From: Mustafa Abduljabbar Date: Mon, 16 Dec 2024 13:28:47 -0500 Subject: [PATCH] Remove unneeded highestTransportType (#1461) [ROCm/rccl commit: e6b179d6275fd852c2e57776ad6da5868f7ba544] --- projects/rccl/src/init.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/projects/rccl/src/init.cc b/projects/rccl/src/init.cc index 738f756beb..2819703a5e 100644 --- a/projects/rccl/src/init.cc +++ b/projects/rccl/src/init.cc @@ -898,7 +898,7 @@ static ncclResult_t collNetInitRailRankMap(ncclComm_t comm) { comm->collNetDenseToUserRank = ncclMemoryStackAlloc(&comm->memPermanent, comm->nRanks); comm->collNetUserToDenseRank = ncclMemoryStackAlloc(&comm->memPermanent, comm->nRanks); - // initialize collNetUserToDenseRank[rank] + // initialize collNetUserToDenseRank[rank] comm->collNetUserToDenseRank[rank] = -1; for (int h = 0; h < comm->collNetHeadsNum; h++) { nonHeadMask ^= 1ull << comm->rankToLocalRank[comm->collNetHeads[h]]; @@ -1244,7 +1244,6 @@ static ncclResult_t initTransportsRank(struct ncclComm* comm, struct ncclComm* p int *topParentLocalRanks = NULL; int tpProxyRank; - int highestTransportType = TRANSPORT_P2P; bool needsProxy = false; bool mscclNeedsProxy = needsProxy; @@ -1701,7 +1700,7 @@ static ncclResult_t initTransportsRank(struct ncclComm* comm, struct ncclComm* p if (comm->nRanks == 1) continue; NCCLCHECKGOTO(ncclTransportP2pConnect(comm, c, 1, &channel->ring.prev, 1, &channel->ring.next, 0), ret, fail); } - NCCLCHECKGOTO(ncclTransportP2pSetup(comm, &ringGraph, 0, &highestTransportType, &needsProxy), ret, fail); + NCCLCHECKGOTO(ncclTransportP2pSetup(comm, &ringGraph, 0, NULL, &needsProxy), ret, fail); mscclNeedsProxy |= needsProxy; if (ringGraph.nIntraChannels && rcclParamP2pNetDisable() == 0) { comm->useIntraNet = 1; @@ -1722,7 +1721,7 @@ static ncclResult_t initTransportsRank(struct ncclComm* comm, struct ncclComm* p NCCLCHECKGOTO(ncclTransportP2pConnect(comm, c, NCCL_MAX_TREE_ARITY, channel->tree.down, 1, &channel->tree.up, 0), ret, fail); NCCLCHECKGOTO(ncclTransportP2pConnect(comm, c, 1, &channel->tree.up, NCCL_MAX_TREE_ARITY, channel->tree.down, 0), ret, fail); } - NCCLCHECKGOTO(ncclTransportP2pSetup(comm, &treeGraph, 0, &highestTransportType, &needsProxy), ret, fail); + NCCLCHECKGOTO(ncclTransportP2pSetup(comm, &treeGraph, 0, NULL, &needsProxy), ret, fail); mscclNeedsProxy |= needsProxy; INFO(NCCL_INIT, "Connected all trees");