Remove hardware IP block based filtering (#820)
* Analysis report block based filtering is the default now
* Update documentation
* Update CHANGELOG
* Fix tests
* Replace hardware block based filtering tests with report block
based filtering tests
[ROCm/rocprofiler-compute commit: 98bb0f4237]
This commit is contained in:
1 parent
2740d18028
commit
46ae3d36d9
15 files changed
+52
-1190
No files matched your search
@@ -64,13 +64,14 @@ def show_all(args, runs, archConfigs, output, profiling_config, roof_plot=None):
|
||||
Show all panels with their data in plain text mode.
|
||||
"""
|
||||
comparable_columns = parser.build_comparable_columns(args.time_unit)
|
||||
filter_panel_ids = [
|
||||
convert_metric_id_to_panel_idx(section)
|
||||
for section in [
|
||||
name
|
||||
for name, type in profiling_config.get("filter_blocks", {}).items()
|
||||
if type == "metric_id"
|
||||
filter_panel_ids = profiling_config.get("filter_blocks", [])
|
||||
if isinstance(filter_panel_ids, dict):
|
||||
# For backward compatibility
|
||||
filter_panel_ids = [
|
||||
name for name, type in filter_panel_ids.items() if type == "metric_id"
|
||||
]
|
||||
filter_panel_ids = [
|
||||
convert_metric_id_to_panel_idx(section) for section in filter_panel_ids
|
||||
]
|
||||
comparable_columns = parser.build_comparable_columns(args.time_unit)
|
||||
|
||||
|
||||
@@ -1142,9 +1142,7 @@ def replace_timestamps(workload_dir):
|
||||
)
|
||||
|
||||
|
||||
def gen_sysinfo(
|
||||
workload_name, workload_dir, ip_blocks, app_cmd, skip_roof, roof_only, mspec, soc
|
||||
):
|
||||
def gen_sysinfo(workload_name, workload_dir, app_cmd, skip_roof, mspec, soc):
|
||||
console_debug("[gen_sysinfo]")
|
||||
df = mspec.get_class_members()
|
||||
|
||||
@@ -1152,12 +1150,7 @@ def gen_sysinfo(
|
||||
df["command"] = app_cmd
|
||||
df["workload_name"] = workload_name
|
||||
|
||||
blocks = []
|
||||
if not ip_blocks:
|
||||
t = ["SQ", "LDS", "SQC", "TA", "TD", "TCP", "TCC", "SPI", "CPC", "CPF"]
|
||||
blocks += t
|
||||
else:
|
||||
blocks += ip_blocks
|
||||
blocks = ["SQ", "LDS", "SQC", "TA", "TD", "TCP", "TCC", "SPI", "CPC", "CPF"]
|
||||
if hasattr(soc, "roofline_obj") and (not skip_roof):
|
||||
blocks.append("roofline")
|
||||
df["ip_blocks"] = "|".join(blocks)
|
||||
@@ -1550,10 +1543,9 @@ def convert_metric_id_to_panel_idx(metric_id):
|
||||
tokens = metric_id.split(".")
|
||||
if len(tokens) == 1:
|
||||
return int(tokens[0]) * 100
|
||||
elif len(tokens) == 2:
|
||||
if len(tokens) == 2:
|
||||
return int(tokens[0]) * 100 + int(tokens[1])
|
||||
else:
|
||||
raise Exception(f"Invalid metric id: {metric_id}")
|
||||
raise Exception(f"Invalid metric id: {metric_id}")
|
||||
|
||||
|
||||
def format_time(seconds):
|
||||
|
||||
Reference in new issue
Block a user