From 46f20fffddb19bfef9608eefd34f3af31c85b808 Mon Sep 17 00:00:00 2001 From: Giovanni LB Date: Tue, 30 Apr 2024 13:11:25 -0300 Subject: [PATCH] SWDEV-459693: Allowing runtime kernels for codeobjects in featureTests Change-Id: I809abcefaa320a3dee6a9d9fc8843162e3e5930e [ROCm/rocprofiler commit: 4ef523c84ab73cb82f6ecc81815a4877d5b6aa47] --- projects/rocprofiler/src/tools/tool.cpp | 4 ++-- .../tests-v2/featuretests/profiler/profiler_gtest.cpp | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/projects/rocprofiler/src/tools/tool.cpp b/projects/rocprofiler/src/tools/tool.cpp index 24361b154b..8d4c37d4a5 100644 --- a/projects/rocprofiler/src/tools/tool.cpp +++ b/projects/rocprofiler/src/tools/tool.cpp @@ -313,8 +313,8 @@ att_parsed_input_t GetATTParams() { std::unordered_map default_params = { {"SE_MASK", 0x111111}, // One every 4 SEs, by default {"SIMD_SELECT", 0x3}, // 0x3 works for both gfx9 and Navi - {"BUFFER_SIZE", 0x10000000}, // 2^28 == 256MB - {"ISA_CAPTURE_MODE", static_cast(ROCPROFILER_CAPTURE_SYMBOLS_ONLY)}}; + {"BUFFER_SIZE", 0xA000000}, // 160MB + {"ISA_CAPTURE_MODE", static_cast(ROCPROFILER_CAPTURE_COPY_MEMORY)}}; std::ifstream trace_file(path); if (!trace_file.is_open()) { diff --git a/projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp b/projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp index 9808b3875f..983ea122c6 100644 --- a/projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp +++ b/projects/rocprofiler/tests-v2/featuretests/profiler/profiler_gtest.cpp @@ -606,18 +606,18 @@ TEST_F(CodeobjTest, WhenRunningProfilerWithCodeobjCapture) { rocprofiler_codeobj_capture_get(id, &capture); EXPECT_EQ(ROCPROFILER_STATUS_SUCCESS, result); - EXPECT_GE(capture.count, 1); - bool bCaptured_itself = false; + EXPECT_GE(capture.count, 2); + int capture_count = 0; for (int i = 0; i < (int)capture.count; i++) { const char* path = capture.symbols[i].filepath; if (!path) continue; std::string fpath(path); - size_t pos = fpath.find("runFeatureTests#offset="); + size_t pos = fpath.find("#offset="); if (pos != std::string::npos && fpath.find("&size=", pos) != std::string::npos) - bCaptured_itself = true; + capture_count ++; } - EXPECT_EQ(bCaptured_itself, true); + EXPECT_GE(capture_count, 2); TearDownRocprofiler(); }