SDK: remove majority of exceptions (#176)

* SDK: remove majority of exceptions

- replace with ROCP_FATAL, ROCP_CI_LOG(WARNING), etc.
- improve logging of symbolic link
- add --readlink and --realpath (hidden options) to rocprofv3 to follow symlinks for preloaded libraries

* Add rocprofv3 --rocm-root argument

* Fix registration resolved_exists

* Fix rocprofv3_avail.py

* Update logging for rocprofiler_configure search

- relax failure conditions

* Misc clang-tidy fixes

* Fix merge

* Fix merge

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

source/lib/output/generateJSON.cpp

@@ -124,21 +124,16 @@ write_json(json_output&         json_ar,
         auto code_object_load_info          = tool_metadata.get_code_object_load_info();
         auto att_filenames                  = tool_metadata.get_att_filenames();
         auto code_object_snapshot_filenames = std::vector<std::string>{};
+
         code_object_snapshot_filenames.reserve(code_object_load_info.size());
         for(const auto& info : code_object_load_info)
-        {
             code_object_snapshot_filenames.emplace_back(fs::path(info.name).filename());
-        }
+
         json_ar.setNextName("strings");
         json_ar.startNode();
         json_ar(cereal::make_nvp("callback_records", callback_name_info));
         json_ar(cereal::make_nvp("buffer_records", buffer_name_info));
         json_ar(cereal::make_nvp("marker_api", marker_msg_data));
-        json_ar(
-            cereal::make_nvp("pc_sample_instructions", tool_metadata.get_pc_sample_instructions()));
-        json_ar(cereal::make_nvp("pc_sample_comments", tool_metadata.get_pc_sample_comments()));
-        json_ar(cereal::make_nvp("att_filenames", att_filenames));
-        json_ar(cereal::make_nvp("code_object_snapshot_filenames", code_object_snapshot_filenames));
         {
             auto _extern_corr_id_strings = std::map<size_t, std::string>{};
             if(cfg.kernel_rename)
@@ -166,6 +161,12 @@ write_json(json_output&         json_ar,
             json_ar.finishNode();
         }
 
+        json_ar(
+            cereal::make_nvp("pc_sample_instructions", tool_metadata.get_pc_sample_instructions()));
+        json_ar(cereal::make_nvp("pc_sample_comments", tool_metadata.get_pc_sample_comments()));
+        json_ar(cereal::make_nvp("att_filenames", att_filenames));
+        json_ar(cereal::make_nvp("code_object_snapshot_filenames", code_object_snapshot_filenames));
+
         json_ar.finishNode();
     }