From 48857c8f0cb5915284ae8d9fd7ede911d3f87987 Mon Sep 17 00:00:00 2001
From: colramos-amd <colramos@amd.com>
Date: Wed, 4 Oct 2023 16:15:48 -0500
Subject: [PATCH] Add support for result comparison in analyze mode

Signed-off-by: colramos-amd <colramos@amd.com>
---
 src/omniperf_analyze/utils/tty.py | 43 +++++++++++++++++++++----------
 src/parser.py                     |  3 +++
 2 files changed, 32 insertions(+), 14 deletions(-)

diff --git a/src/omniperf_analyze/utils/tty.py b/src/omniperf_analyze/utils/tty.py
index d04dc2cb9a..015d8af421 100644
--- a/src/omniperf_analyze/utils/tty.py
+++ b/src/omniperf_analyze/utils/tty.py
@@ -25,6 +25,7 @@
 import pandas as pd
 from pathlib import Path
 from tabulate import tabulate
+import sys
 
 from omniperf_analyze.utils import schema, parser
 
@@ -110,20 +111,23 @@ def show_all(args, runs, archConfigs, output):
                                             float(x) if x != "" else float(0)
                                             for x in cur_df[header]
                                         ]
-                                        t_df = (
-                                            pd.concat(
-                                                [
-                                                    base_df[header],
-                                                    cur_df[header],
-                                                ],
-                                                axis=1,
-                                            )
-                                            .pct_change(axis="columns")
-                                            .iloc[:, 1]
+                                        t_df = pd.concat(
+                                            [
+                                                base_df[header],
+                                                cur_df[header],
+                                            ],
+                                            axis=1,
                                         )
+                                        diff = t_df.iloc[:, 1] - t_df.iloc[:, 0]
+                                        t_df = diff / t_df.iloc[:, 0].replace(0, 1)
                                         if args.verbose >= 2:
                                             print("---------", header, t_df)
 
+                                        t_df_pretty = (
+                                            t_df.astype(float)
+                                            .mul(100)
+                                            .round(args.decimal)
+                                        )
                                         # show value + percentage
                                         # TODO: better alignment
                                         t_df = (
@@ -132,12 +136,23 @@ def show_all(args, runs, archConfigs, output):
                                             .round(args.decimal)
                                             .map(str)
                                             + " ("
-                                            + t_df.astype(float)
-                                            .mul(100)
-                                            .round(args.decimal)
-                                            .map(str)
+                                            + t_df_pretty.map(str)
                                             + "%)"
                                         )
+                                        # DEBUG: When in a CI setting and flag is set,
+                                        #       then verify metrics meet threshold requirement
+                                        if args.report_diff:
+                                            if (
+                                                t_df_pretty.abs()
+                                                .gt(args.report_diff)
+                                                .any()
+                                            ):
+                                                print(
+                                                    "DEBUG ERROR: Dataframe diff exceeds {} threshold requirement".format(
+                                                        str(args.report_diff) + "%"
+                                                    )
+                                                )
+                                                sys.exit(1)
 
                                         df = pd.concat([df, t_df], axis=1)
                                     else:
diff --git a/src/parser.py b/src/parser.py
index 1a692cc162..38f020af8e 100644
--- a/src/parser.py
+++ b/src/parser.py
@@ -522,3 +522,6 @@ def parse(my_parser):
         default=5,
         type=int,
     )
+    analyze_group.add_argument(
+        "--report-diff", default=0, nargs="?", type=int, help=argparse.SUPPRESS
+    )