Address and thread sanitizer fixes (#250)
* Address and thread sanitizer fixes
- Fix compilation with clang
- Tweak perfetto copy to build tree
- Added suppression files to scripts
- fix LD_PRELOAD support in omnitrace-causal and omnitrace-sample
- use spin_mutex and spin_lock from timemory instead of atomic_mutex and atomic_lock
- state uses atomic
- fix some memory leaks
- tweak testing
- mpi tests do not use preload
- increase timeout when using sanitizers
- add env LD_PRELOAD when using sanitizers
* Tweak perfetto build
* Update timemory submodule
* Update version to 1.8.1
* Update omnitrace-leak.supp
* Update timemory submodule
- fixed spin_mutex implementation
* Remove previously added addr_space->allowTraps(instr_traps)
- this appears to cause errors during binary rewrite
* causal testing updates
- relaxed causal validation on CI systems (to account for hyperthreading decreasing prediction)
- improved impact calculation
- other general improvements to validate-causal-json.py
* Improve fork handling for perfetto
- numerous updates changing perfetto:: to ::perfetto::
- added perfetto_fwd.hpp
* Updated fork example
- user API for validation that stopping/starting perfetto is valid
* Misc fixes to perfetto + fork support
- tweak regions in fork example
- handle disabling tmp files
- get rid of stop/start with perfetto before/after fork
- fixed sampling support during fork
- tweak env of fork test
* Fix find_package in build-tree
* Fix buildtree export
* Fix buildtree export
* Restructured ConfigInstall before adding examples
* Guard against creating tmp file in sampling when disabled
* Fix buildtree package
* formatting
* exit handlers on child processes
- quick exit to avoid perfetto cleanup
* Further tweaking of causal tests for reliability
- enable PROCESSOR_AFFINITY
- decrease to 5 iterations
* Further tweaking of causal tests for reliability
- disable PROCESSOR_AFFINITY for fast func e2e tests
- enabling affinity results in (valid) speedup predictions greater than zero
* Fixes to fork handling
- use pthread_atfork for redundancy if fork_gotcha fails
* cmake formatting
* Fix fork init settings + install components
- remove dl from PROJECT_BUILD_TARGETS
* Testing tweaks
- fix mpi-binary-rewrite-run regex when OMNITRACE_VERBOSE set > 1 in env
- increase causal e2e iterations to 8
* Fix "Test User API"
- test-find-package.sh included dl component
* Further tweaks to causal validation
- further considerations of variance
[ROCm/rocprofiler-systems commit: 846301bcaf]
This commit is contained in:
committed by
GitHub
parent
7d0fb66465
commit
49851b05ae
@@ -370,7 +370,17 @@ start_duration_thread()
|
||||
auto&
|
||||
get_offload_file()
|
||||
{
|
||||
static auto _v = config::get_tmp_file("sampling");
|
||||
static auto _v = []() {
|
||||
auto _tmp_v = config::get_tmp_file("sampling");
|
||||
if(get_use_tmp_files())
|
||||
{
|
||||
auto _success = _tmp_v->open();
|
||||
OMNITRACE_CI_FAIL(!_success,
|
||||
"Error opening sampling offload temporary file '%s'\n",
|
||||
_tmp_v->filename.c_str());
|
||||
}
|
||||
return _tmp_v;
|
||||
}();
|
||||
return _v;
|
||||
}
|
||||
|
||||
@@ -853,7 +863,7 @@ post_process()
|
||||
if(itr) itr.reset();
|
||||
}
|
||||
|
||||
if(get_offload_file())
|
||||
if(get_use_tmp_files() && get_offload_file())
|
||||
{
|
||||
get_offload_file()->remove();
|
||||
get_offload_file().reset();
|
||||
@@ -917,7 +927,7 @@ post_process_perfetto(int64_t _tid, const bundle_t* _init,
|
||||
_thread_info->index_data->sequent_value, _thread_info->index_data->system_value);
|
||||
|
||||
tracing::push_perfetto_track(category::sampling{}, "samples [omnitrace]", _track,
|
||||
_beg_ns, [&](perfetto::EventContext ctx) {
|
||||
_beg_ns, [&](::perfetto::EventContext ctx) {
|
||||
if(config::get_perfetto_annotations())
|
||||
{
|
||||
tracing::add_perfetto_annotation(ctx, "begin_ns",
|
||||
@@ -1002,7 +1012,7 @@ post_process_perfetto(int64_t _tid, const bundle_t* _init,
|
||||
auto _info = JOIN(':', litr.location, litr.line);
|
||||
tracing::push_perfetto_track(
|
||||
category::sampling{}, _name, _track, _beg,
|
||||
[&](perfetto::EventContext ctx) {
|
||||
[&](::perfetto::EventContext ctx) {
|
||||
if(config::get_perfetto_annotations())
|
||||
{
|
||||
_common_annotate(ctx, (_n == 0 && _ncur == 0) ||
|
||||
@@ -1023,7 +1033,7 @@ post_process_perfetto(int64_t _tid, const bundle_t* _init,
|
||||
const auto* _name = _static_strings.emplace(iitr.name).first->c_str();
|
||||
tracing::push_perfetto_track(
|
||||
category::sampling{}, _name, _track, _beg,
|
||||
[&](perfetto::EventContext ctx) {
|
||||
[&](::perfetto::EventContext ctx) {
|
||||
if(config::get_perfetto_annotations())
|
||||
{
|
||||
_common_annotate(ctx, true);
|
||||
@@ -1057,7 +1067,7 @@ post_process_perfetto(int64_t _tid, const bundle_t* _init,
|
||||
}
|
||||
|
||||
tracing::pop_perfetto_track(category::sampling{}, "samples [omnitrace]", _track,
|
||||
_end_ns, [&](perfetto::EventContext ctx) {
|
||||
_end_ns, [&](::perfetto::EventContext ctx) {
|
||||
if(config::get_perfetto_annotations())
|
||||
{
|
||||
tracing::add_perfetto_annotation(ctx, "end_ns",
|
||||
|
||||
Reference in New Issue
Block a user