Replace fan test failure with warning
In some cases, the fan sysfs files will exist even if the device doesn't have a fan. In these cases, the tests will give apparently random results. Also, remove documentation and ifdef'd test of debugfs related power functions.
This commit is contained in:
@@ -316,8 +316,13 @@ static rsmi_status_t test_set_fan_speed(uint32_t dv_ind) {
|
||||
std::cout << "New fan speed: " << cur_speed << std::endl;
|
||||
}
|
||||
|
||||
EXPECT_TRUE((cur_speed > 0.95 * new_speed && cur_speed < 1.1 * new_speed) ||
|
||||
cur_speed > 0.95 * RSMI_MAX_FAN_SPEED);
|
||||
// EXPECT_TRUE((cur_speed > 0.95 * new_speed && cur_speed < 1.1 * new_speed) ||
|
||||
// cur_speed > 0.95 * RSMI_MAX_FAN_SPEED);
|
||||
if (!((cur_speed > 0.95 * new_speed && cur_speed < 1.1 * new_speed) ||
|
||||
(cur_speed > 0.95 * RSMI_MAX_FAN_SPEED))) {
|
||||
std::cout << "WARNING: Fan speed is not within the expected range!" <<
|
||||
std::endl;
|
||||
}
|
||||
|
||||
IF_VERB(STANDARD) {
|
||||
std::cout << "Resetting fan control to auto..." << std::endl;
|
||||
@@ -805,24 +810,6 @@ void TestSanity::Run(void) {
|
||||
IF_VERB(STANDARD) {
|
||||
std::cout << "\t**Current fan RPMs: " << val_i64 << std::endl;
|
||||
}
|
||||
#if 0 // Apparently recent change in debug fs causes crash here.
|
||||
// Disable able this for now until we debug error path.
|
||||
err = rsmi_dev_power_max_get(i, &val_ui64);
|
||||
if (err == RSMI_STATUS_NOT_SUPPORTED) {
|
||||
const char *s_str;
|
||||
err = rsmi_status_string(RSMI_STATUS_NOT_SUPPORTED, &s_str);
|
||||
CHK_ERR_ASRT(err)
|
||||
std::cout << "\t**rsmi_dev_power_max_get(): " << s_str << std::endl;
|
||||
} else {
|
||||
IF_VERB(STANDARD) {
|
||||
std::cout << "\t**Max Power Usage: ";
|
||||
CHK_RSMI_PERM_ERR(err)
|
||||
if (err == RSMI_STATUS_SUCCESS) {
|
||||
std::cout << static_cast<float>(val_ui64)/1000 << " W" << std::endl;
|
||||
}
|
||||
}
|
||||
}
|
||||
#endif
|
||||
err = rsmi_dev_power_cap_get(i, 0, &val_ui64);
|
||||
CHK_ERR_ASRT(err)
|
||||
IF_VERB(STANDARD) {
|
||||
|
||||
Reference in New Issue
Block a user