Fix hash_for undefined reference in hipTestConstant test
Issue: mismatch undefined symbols in different user env
- Binary expects modified return value std::string&
- Fails to match libhip_hcc.so: return value is std::string& but doesn't match modified C++ env
Fix: Change return value to char*, create new key std::string in header from char*
[ROCm/hip commit: 23e9968752]
Ta zmiana jest zawarta w:
%! (template.HTML=
Aaron Enye Shi)złożyło 2019-03-11 19:51:18 +00:00
1 rodzic
645c29159c
złożenie
4b87bd25e8
2 plików zmienionych
+5
-4
Żadne pliki nie pasują do Twojego wyszukiwania
@@ -2518,7 +2518,7 @@ struct Agent_global {
|
||||
|
||||
namespace hip_impl {
|
||||
hsa_executable_t executable_for(hipModule_t);
|
||||
const std::string& hash_for(hipModule_t);
|
||||
const char* hash_for(hipModule_t);
|
||||
|
||||
template<typename ForwardIterator>
|
||||
std::pair<hipDeviceptr_t, std::size_t> read_global_description(
|
||||
@@ -2543,7 +2543,8 @@ hipError_t read_agent_global_from_module(hipDeviceptr_t* dptr, size_t* bytes,
|
||||
// hipModule_t instance
|
||||
static std::unordered_map<
|
||||
std::string, std::vector<Agent_global>> agent_globals;
|
||||
auto key = hash_for(hmod);
|
||||
const char* hash = hash_for(hmod);
|
||||
std::string key(hash);
|
||||
|
||||
if (agent_globals.count(key) == 0) {
|
||||
static std::mutex mtx;
|
||||
|
||||
Reference in new issue
Zablokuj użytkownika