From 4b99cef680df9404a368d3c8520305591c583f22 Mon Sep 17 00:00:00 2001 From: Wenkai Du <43822138+wenkaidu@users.noreply.github.com> Date: Wed, 6 Jul 2022 10:07:35 -0700 Subject: [PATCH] Revert "Adding the missing roc:: namespace (#570)" (#576) This reverts commit fc340decf418a2aacf69517210d90f910b9e5192. [ROCm/rccl commit: 2e65881a7954fb6277fd3ccc2707be5b27315f64] --- projects/rccl/CHANGELOG.md | 2 -- projects/rccl/CMakeLists.txt | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/projects/rccl/CHANGELOG.md b/projects/rccl/CHANGELOG.md index 0feab091bd..e0e7913240 100644 --- a/projects/rccl/CHANGELOG.md +++ b/projects/rccl/CHANGELOG.md @@ -5,8 +5,6 @@ Full documentation for RCCL is available at [https://rccl.readthedocs.io](https: ## (Unreleased) RCCL-2.12.10 ### Added - Compatibility with NCCL 2.12.10 -- Changing CMake exported target name from rccl to roc::rccl. This aligns RCCL to other ROCm - components. Users may need to update their build systems. - Packages for test and benchmark executables on all supported OSes using CPack. - Adding custom signal handler - opt-in with RCCL_ENABLE_SIGNALHANDLER=1 - Additional details provided if Binary File Descriptor library (BFD) is pre-installed diff --git a/projects/rccl/CMakeLists.txt b/projects/rccl/CMakeLists.txt index 508933f7e4..79e0a359cc 100644 --- a/projects/rccl/CMakeLists.txt +++ b/projects/rccl/CMakeLists.txt @@ -358,7 +358,7 @@ rocm_install(FILES ${PROJECT_BINARY_DIR}/include/rccl/rccl.h rocm_export_targets(NAMESPACE roc:: TARGETS - roc::rccl + rccl DEPENDS hip) if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY)