[rocprofiler-sdk] Update rocprofiler-sdk CONTRIBUTING.md (#1371)

This commit is contained in:
Jonathan R. Madsen
2025-10-20 21:46:24 -05:00
committed by GitHub
parent 32f9fa6ca5
commit 4cca398b56
23 changed files with 348 additions and 106 deletions
@@ -529,42 +529,32 @@ PYBIND11_MODULE(libpyrocpd, pyrocpd)
// (1) the process with the earliest start time
// (2) find the process with the longest duration
uint64_t min_start_time = std::numeric_limits<uint64_t>::max();
uint64_t max_fini_time = 0;
uint64_t max_fini_time = std::numeric_limits<uint64_t>::min();
for(auto obj : {data.connection})
{
auto* conn = rocpd::interop::get_connection(std::move(obj));
// min start
sqlite3_stmt* _stmt_min_start;
sqlite3_prepare_v2(
conn, "SELECT MIN(start) FROM processes;", -1, &_stmt_min_start, nullptr);
uint64_t _min_start_time = std::numeric_limits<uint64_t>::max();
if(sqlite3_step(_stmt_min_start) == SQLITE_ROW)
sqlite3_stmt* _stmt_min_start_max_fini = nullptr;
uint64_t _min_start_time = std::numeric_limits<uint64_t>::max();
uint64_t _max_fini_time = std::numeric_limits<uint64_t>::min();
sqlite3_prepare_v2(conn,
"SELECT MIN(start), MAX(fini) FROM processes;",
-1,
&_stmt_min_start_max_fini,
nullptr);
if(sqlite3_step(_stmt_min_start_max_fini) == SQLITE_ROW)
{
_min_start_time =
static_cast<uint64_t>(sqlite3_column_int64(_stmt_min_start, 0));
static_cast<uint64_t>(sqlite3_column_int64(_stmt_min_start_max_fini, 0));
_max_fini_time =
static_cast<uint64_t>(sqlite3_column_int64(_stmt_min_start_max_fini, 1));
}
sqlite3_finalize(_stmt_min_start);
if(min_start_time > _min_start_time)
{
min_start_time = _min_start_time;
}
//// max fini
sqlite3_stmt* _stmt_max_fini;
sqlite3_prepare_v2(
conn, "SELECT MAX(fini) FROM processes;", -1, &_stmt_max_fini, nullptr);
uint64_t _max_fini_time = 0;
if(sqlite3_step(_stmt_max_fini) == SQLITE_ROW)
{
_max_fini_time = static_cast<uint64_t>(sqlite3_column_int64(_stmt_max_fini, 0));
}
sqlite3_finalize(_stmt_max_fini);
if(max_fini_time < _max_fini_time)
{
max_fini_time = _max_fini_time;
}
sqlite3_finalize(_stmt_min_start_max_fini);
min_start_time = std::min(min_start_time, _min_start_time);
max_fini_time = std::max(max_fini_time, _max_fini_time);
}
auto otf2_session =
@@ -538,9 +538,9 @@ write_otf2(const OTF2Session& otf2_session,
get_hash_id(_name),
region_info{_name, OTF2_REGION_ROLE_DATA_TRANSFER, OTF2_PARADIGM_HIP});
auto _extended_agent = agent_data.at(itr.dst_agent_abs_index);
auto _agent_handle = _extended_agent.types_agent.id.handle;
auto _evt_info = event_info{location_base{
const auto& _extended_agent = agent_data.at(itr.dst_agent_abs_index);
auto _agent_handle = _extended_agent.types_agent.id.handle;
auto _evt_info = event_info{location_base{
process.pid, itr.tid, _agent_handle, ROCPROFILER_AGENT_MEMORY_COPY_TYPE}};
auto agent_index_info = _extended_agent.agent_index;
@@ -587,8 +587,8 @@ write_otf2(const OTF2Session& otf2_session,
get_hash_id(_alloc_operation),
region_info{_alloc_operation, OTF2_REGION_ROLE_ALLOCATE, OTF2_PARADIGM_HIP});
auto _extended_agent = agent_data.at(itr.agent_abs_index);
auto _handle = _extended_agent.types_agent.id.handle;
const auto& _extended_agent = agent_data.at(itr.agent_abs_index);
auto _handle = _extended_agent.types_agent.id.handle;
auto _evt_info = event_info{location_base{
process.pid, itr.tid, _handle, ROCPROFILER_AGENT_MEMORY_ALLOC_TYPE}};
@@ -672,9 +672,9 @@ write_otf2(const OTF2Session& otf2_session,
_attr_str.emplace(get_hash_id(_perfetto_name), _perfetto_name);
auto* _attrs = create_attribute_list_for_name(_perfetto_name);
auto _extended_agent = agent_data.at(itr.agent_abs_index);
auto _handle = _extended_agent.types_agent.id.handle;
auto agent_index_info = _extended_agent.agent_index;
const auto& _extended_agent = agent_data.at(itr.agent_abs_index);
auto _handle = _extended_agent.types_agent.id.handle;
auto agent_index_info = _extended_agent.agent_index;
auto _evt_info = event_info{location_base{
process.pid, itr.tid, _handle, ROCPROFILER_AGENT_DISPATCH_TYPE, itr.queue_id}};