Misc cleanup and stale code removal (#1026)

* Remove custom allocators

- remove unused lib/rocprofiler-sdk/allocator.*
- remove unused lib/rocprofiler-sdk/context/allocator.hpp

* Fix rocprofiler_strip_target (rocprofiler_utilities.cmake)

* Remove old HSA_TOOLS_LIB support

- remove OnLoad/OnUnload functions used by HSA_TOOLS_LIB env variable

* Fix linter warnings + specific NOLINT exceptions

- replace bare NOLINT with NOLINT(<warning-name>)

[ROCm/rocprofiler-sdk commit: 5d54682468]

projects/rocprofiler-sdk/tests/bin/page-migration/page-migration.cpp

@@ -80,7 +80,7 @@ struct mmap_allocator
                          MAP_ANONYMOUS | MAP_PRIVATE,  // flags: No file handle
                          -1,                           // no fd, use memory "MAP_ANONYMOUS"
                          0);                           // offset into fd
-        if(ret == ((void*) -1))                        // NOLINT performance-no-int-to-ptr
+        if(ret == ((void*) -1))                        // NOLINT(performance-no-int-to-ptr)
         {
             auto ecode = errno;
             fprintf(stderr, "mmap error %d: %s", ecode, strerror(ecode));

projects/rocprofiler-sdk/tests/common/filesystem.hpp

@@ -67,11 +67,11 @@ namespace common
 {
 #if defined(ROCPROFILER_TESTS_HAS_GHC_LIB_FILESYSTEM) &&                                           \
     ROCPROFILER_TESTS_HAS_GHC_LIB_FILESYSTEM > 0
-namespace fs = ::ghc::filesystem;  // NOLINT
+namespace fs = ::ghc::filesystem;  // NOLINT(misc-unused-alias-decls)
 #elif defined(ROCPROFILER_TESTS_HAS_CPP_LIB_FILESYSTEM) &&                                         \
     ROCPROFILER_TESTS_HAS_CPP_LIB_FILESYSTEM > 0
-namespace fs = ::std::filesystem;  // NOLINT
+namespace fs = ::std::filesystem;  // NOLINT(misc-unused-alias-decls)
 #else
-namespace fs = ::std::experimental::filesystem;  // NOLINT
+namespace fs = ::std::experimental::filesystem;  // NOLINT(misc-unused-alias-decls)
 #endif
 }  // namespace common

projects/rocprofiler-sdk/tests/pc_sampling/CMakeLists.txt

@@ -127,16 +127,14 @@ add_test(NAME pc-sampling-integration-test
 
 set_tests_properties(
     pc-sampling-integration-test
-    PROPERTIES
-        TIMEOUT
-        45
-        LABELS
-        "integration-tests;pc-sampling"
-        # ENVIRONMENT
-        # "${ROCPROFILER_MEMCHECK_PRELOAD_ENV};HSA_TOOLS_LIB=$<TARGET_FILE:rocprofiler::rocprofiler-shared-library>"
-        SKIP_REGULAR_EXPRESSION
-        "PC sampling unavailable"
-        ENVIRONMENT
-        "${pc-sampling-integration-test-env}"
-        FAIL_REGULAR_EXPRESSION
-        "${ROCPROFILER_DEFAULT_FAIL_REGEX}")
+    PROPERTIES TIMEOUT
+               45
+               LABELS
+               "integration-tests;pc-sampling"
+               # ENVIRONMENT "${ROCPROFILER_MEMCHECK_PRELOAD_ENV}"
+               SKIP_REGULAR_EXPRESSION
+               "PC sampling unavailable"
+               ENVIRONMENT
+               "${pc-sampling-integration-test-env}"
+               FAIL_REGULAR_EXPRESSION
+               "${ROCPROFILER_DEFAULT_FAIL_REGEX}")