[SDK] Fix null handles (#474)
* Fix null handle - use .handle=0, not .handle=numeric_limits<>::max() * Update lib.common.hasher * Fix ROCPROFILER_CONTEXT_NONE * Use context operator== * Update CHANGELOG * Updated null handle for scratch memory and changed allocation test so that free ops account for null agent --------- Co-authored-by: Ian Trowbridge <Ian.Trowbridge@amd.com>
Этот коммит содержится в:
1 родитель
fcfb5bd918
Коммит
4d6a61f5e5
12 files changed
+75
-50
No files matched your search
@@ -159,8 +159,7 @@ rocprofiler_configure_buffer_tracing_service(rocprofiler_context_id_t
|
||||
|
||||
if(buffer_id.handle == 0) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
|
||||
|
||||
constexpr auto invalid_buffer_id =
|
||||
rocprofiler_buffer_id_t{std::numeric_limits<uint64_t>::max()};
|
||||
constexpr auto invalid_buffer_id = rocprofiler_buffer_id_t{0};
|
||||
|
||||
if(!ctx->buffered_tracer)
|
||||
{
|
||||
@@ -168,7 +167,7 @@ rocprofiler_configure_buffer_tracing_service(rocprofiler_context_id_t
|
||||
ctx->buffered_tracer->buffer_data.fill(invalid_buffer_id);
|
||||
}
|
||||
|
||||
if(ctx->buffered_tracer->buffer_data.at(kind).handle != invalid_buffer_id.handle)
|
||||
if(ctx->buffered_tracer->buffer_data.at(kind) != invalid_buffer_id)
|
||||
return ROCPROFILER_STATUS_ERROR_SERVICE_ALREADY_CONFIGURED;
|
||||
|
||||
RETURN_STATUS_ON_FAIL(rocprofiler::context::add_domain(ctx->buffered_tracer->domains, kind));
|
||||
|
||||
Reference in new issue
Block a user