From 4ebc34095cf40a53718552d49bbbdd7104f79e16 Mon Sep 17 00:00:00 2001 From: "Galantsev, Dmitrii" Date: Tue, 30 Jul 2024 12:34:02 -0500 Subject: [PATCH] INSTALL - Always add video group to rdc user Previously we relied on "render" to be enough and only used "video" as a fallback. On some systems like SLES this might not be sufficient. One issue happened when starting rocprofiler as part of RDC initialization: what(): hsa error code: 4104 HSA_STATUS_ERROR_OUT_OF_RESOURCES The issue only happened when RDC was started with systemd. Turns out "rdc" user (under which systemctl starts RDC) only had render but not video group. Adding video group solved the issue. Change-Id: Idf6a9521ae72a0b28a428869aa7ab1edde3ae259 Signed-off-by: Galantsev, Dmitrii --- src/DEBIAN_postinst.in | 7 +++++-- src/RPM_rpm_post.in | 6 ++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/DEBIAN_postinst.in b/src/DEBIAN_postinst.in index 71a6bc84a1..9806e829cf 100755 --- a/src/DEBIAN_postinst.in +++ b/src/DEBIAN_postinst.in @@ -62,11 +62,14 @@ do_create_rdc_user() { --no-create-home \ --disabled-password \ rdc + # only add render if it exists if [ $(getent group render) ]; then usermod -a -G render rdc - else - usermod -a -G video rdc fi + + # add video always + usermod -a -G video rdc + # Make sure this doesn't return non-zero if an id already exists return 0 } diff --git a/src/RPM_rpm_post.in b/src/RPM_rpm_post.in index 658c1298a0..88d3a3ebf4 100755 --- a/src/RPM_rpm_post.in +++ b/src/RPM_rpm_post.in @@ -53,12 +53,14 @@ do_update_alternatives(){ # https://fedoraproject.org/wiki/Packaging%3aUsersAndGroups do_create_rdc_user() { useradd -r -s /sbin/nologin rdc + # only add render if it exists if [ $(getent group render) ]; then usermod -a -G render rdc - else - usermod -a -G video rdc fi + # add video always + usermod -a -G video rdc + # Make sure this doesn't return non-zero if an id already exists return 0 }