Fix few memory leaks in HIP (#1969)

[ROCm/clr commit: 4a68ab5a8c]

projects/clr/hipamd/samples/0_Intro/module_api/defaultDriver.cpp

@@ -80,8 +80,8 @@ int main() {
 
     hipFree(Ad);
     hipFree(Bd);
-    delete A;
+    delete[] A;
-    delete B;
+    delete[] B;
     hipCtxDestroy(context);
     return 0;
 }

projects/clr/hipamd/samples/0_Intro/module_api/launchKernelHcc.cpp

@@ -107,8 +107,8 @@ int main() {
 
     hipFree(Ad);
     hipFree(Bd);
-    delete A;
+    delete[] A;
-    delete B;
+    delete[] B;
     hipCtxDestroy(context);
     return 0;
 }

projects/clr/hipamd/samples/0_Intro/module_api/runKernel.cpp

@@ -99,8 +99,8 @@ int main() {
 
     hipFree(Ad);
     hipFree(Bd);
-    delete A;
+    delete[] A;
-    delete B;
+    delete[] B;
     hipCtxDestroy(context);
     return 0;
 }

projects/clr/hipamd/samples/0_Intro/module_api_global/runKernel.cpp

@@ -154,8 +154,8 @@ int main() {
 
     hipFree(Ad);
     hipFree(Bd);
-    delete A;
+    delete[] A;
-    delete B;
+    delete[] B;
     hipCtxDestroy(context);
     return 0;
 }

projects/clr/hipamd/src/hip_module.cpp

@@ -330,22 +330,18 @@ hipError_t ihipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList
         return hipErrorInvalidValue;
     }
 
-    hipFunction_t* kds = reinterpret_cast<hipFunction_t*>(malloc(sizeof(hipFunction_t) * numDevices));
+    std::vector<hipFunction_t> kds(numDevices,0);
-    if (kds == nullptr) {
-        return hipErrorNotInitialized;
-    }
 
     // prepare all kernel descriptors for each device as all streams will be locked in the next loop
     for (int i = 0; i < numDevices; ++i) {
         const hipLaunchParams& lp = launchParamsList[i];
         if (lp.stream == nullptr) {
-            free(kds);
             return hipErrorNotInitialized;
         }
         kds[i] = ps.kernel_descriptor(reinterpret_cast<std::uintptr_t>(lp.func),
                 hip_impl::target_agent(lp.stream));
+
         if (kds[i] == nullptr) {
-            free(kds);
             return hipErrorInvalidValue;
         }
         hip_impl::kernargs_size_align kargs = ps.get_kernargs_size_align(
@@ -398,8 +394,6 @@ hipError_t ihipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList
  #endif
      }
 
-    free(kds);
-
     return result;
 }
 

projects/clr/hipamd/src/hip_texture.cpp

@@ -312,6 +312,7 @@ hipError_t hipCreateTextureObject(hipTextureObject_t* pTexObject, const hipResou
                                       HSA_EXT_IMAGE_DATA_LAYOUT_LINEAR, pitch, 0, &(pTexture->image)) ||
             HSA_STATUS_SUCCESS !=
                 hsa_ext_sampler_create(*agent, &samplerDescriptor, &(pTexture->sampler))) {
+            free(pTexture);
             return ihipLogStatus(hipErrorRuntimeOther);
         }
 
@@ -449,6 +450,7 @@ hipError_t ihipBindTextureImpl(TlsData *tls_, int dim, enum hipTextureReadMode r
                                       HSA_EXT_IMAGE_DATA_LAYOUT_LINEAR, rowPitch, 0, &(pTexture->image)) ||
             HSA_STATUS_SUCCESS !=
                 hsa_ext_sampler_create(*agent, &samplerDescriptor, &(pTexture->sampler))) {
+            free(pTexture);
             return hipErrorRuntimeOther;
         }
         getHipTextureObject(&textureObject, pTexture->image, pTexture->sampler);
@@ -525,6 +527,7 @@ hipError_t ihipBindTexture2DImpl(TlsData *tls, int dim, enum hipTextureReadMode
                                       HSA_EXT_IMAGE_DATA_LAYOUT_LINEAR, pitch, 0, &(pTexture->image)) ||
             HSA_STATUS_SUCCESS !=
                 hsa_ext_sampler_create(*agent, &samplerDescriptor, &(pTexture->sampler))) {
+            free(pTexture);
             return hipErrorRuntimeOther;
         }
         getHipTextureObject(&textureObject, pTexture->image, pTexture->sampler);

projects/clr/hipamd/tests/src/runtimeApi/module/hipModuleLoadDataMultThreaded.cpp

@@ -107,8 +107,8 @@ void run(const std::vector<char>& buffer) {
    
     hipFree(Ad); 
     hipFree(Bd); 
-    delete A;
+    delete[] A;
-    delete B;
+    delete[] B;
     hipCtxDestroy(context);
     
 }