From 4f955324ac134d2e1fc470a7f922c8147aa332b1 Mon Sep 17 00:00:00 2001 From: Yiltan Date: Mon, 29 Sep 2025 14:27:25 -0400 Subject: [PATCH] Fix g/p tests (#266) [ROCm/rocshmem commit: 6bb46887e872cdcdfd1c071451115a5a40539ff4] --- .../tests/functional_tests/primitive_tester.cpp | 12 +++++------- .../tests/functional_tests/tester_arguments.cpp | 4 ++++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/projects/rocshmem/tests/functional_tests/primitive_tester.cpp b/projects/rocshmem/tests/functional_tests/primitive_tester.cpp index bdba1a95b5..83b3953f42 100644 --- a/projects/rocshmem/tests/functional_tests/primitive_tester.cpp +++ b/projects/rocshmem/tests/functional_tests/primitive_tester.cpp @@ -82,16 +82,14 @@ __global__ void PrimitiveTest(int loop, int skip, long long int *start_time, rocshmem_ctx_putmem_nbi(ctx, dest, source, size, 1); break; case PTestType: - for (int s = 0; s < size; s++) { - char val = source[s]; - rocshmem_ctx_char_p(ctx, &dest[s], val, 1); + { + /* Assigment required to verify we can send non-symetric memory */ + char val = *source; + rocshmem_ctx_char_p(ctx, dest, val, 1); } break; case GTestType: - for (int s = 0; s < size; s++) { - char ret = rocshmem_ctx_char_g(ctx, &source[s], 1); - dest[s] = ret; - } + *dest = rocshmem_ctx_char_g(ctx, source, 1); break; default: break; diff --git a/projects/rocshmem/tests/functional_tests/tester_arguments.cpp b/projects/rocshmem/tests/functional_tests/tester_arguments.cpp index 2394947331..835d59fd5a 100644 --- a/projects/rocshmem/tests/functional_tests/tester_arguments.cpp +++ b/projects/rocshmem/tests/functional_tests/tester_arguments.cpp @@ -121,6 +121,10 @@ TesterArguments::TesterArguments(int argc, char *argv[]) { case PutNBIMRTestType: min_msg_size = max_msg_size; break; + case PTestType: + case GTestType: + min_msg_size = 1; + max_msg_size = 1; default: break; }