From 4ff89b6fd1353ee5473d8dd64ad8ab1434c95414 Mon Sep 17 00:00:00 2001 From: Charis Poag Jones <149186100+charis-poag-amd@users.noreply.github.com> Date: Thu, 4 Dec 2025 09:29:01 -0600 Subject: [PATCH] [SWDEV-570457] Fix Python 3.8/3.7 typing errors (#2164) Changes: - Fixed `amd-smi` showing: ```console $ amd-smi Traceback (most recent call last): File "/opt/rocm/bin/amd-smi", line 53, in from amdsmi_init import * File "/opt/rocm/libexec/amdsmi_cli/amdsmi_init.py", line 38, in from amdsmi import amdsmi_interface, amdsmi_exception File "/usr/local/lib/python3.8/dist-packages/amdsmi/__init__.py", line 24, in from .amdsmi_interface import amdsmi_init File "/usr/local/lib/python3.8/dist-packages/amdsmi/amdsmi_interface.py", line 5581, in ) -> tuple[int, int]: TypeError: 'type' object is not subscriptable ``` This was a python3.8 issue, which is now resolved by using `Tuple[int, int]` typing for Python 3.8 compatibility. --- projects/amdsmi/py-interface/amdsmi_interface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/amdsmi/py-interface/amdsmi_interface.py b/projects/amdsmi/py-interface/amdsmi_interface.py index 43dba82ec8..656c6ef0be 100644 --- a/projects/amdsmi/py-interface/amdsmi_interface.py +++ b/projects/amdsmi/py-interface/amdsmi_interface.py @@ -5578,7 +5578,7 @@ def amdsmi_set_gpu_ptl_state( def amdsmi_get_gpu_ptl_formats( processor_handle: processor_handle_t - ) -> tuple[int, int]: + ) -> Tuple[int, int]: if not isinstance(processor_handle, amdsmi_wrapper.amdsmi_processor_handle): raise AmdSmiParameterException(processor_handle, amdsmi_wrapper.amdsmi_processor_handle) data_format1 = amdsmi_wrapper.amdsmi_ptl_data_format_t()