From 51bdb2ce02e2c5b4562ce47ab91eb8deb9115eeb Mon Sep 17 00:00:00 2001
From: Xianwei Zhang <Xianwei.Zhang@amd.com>
Date: Fri, 23 Aug 2019 12:14:48 -0700
Subject: [PATCH] tests: replace 'bc' with 'awk' to be more portable

Calbulator package 'bc' is not always installed, occasionally
breaking the test scripts. As a fix, this patch gets rid of
'bc' and uses 'awk' instead.

Change-Id: I5f4dbf018d97581a626cf95d147c415755477771
---
 .../run_scripts/test_cache_miss.sh             | 18 +++++++++---------
 .../run_scripts/test_fetchwrite_size.sh        |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/test/memory_validation/run_scripts/test_cache_miss.sh b/test/memory_validation/run_scripts/test_cache_miss.sh
index 89418258a3..7adf6091f8 100755
--- a/test/memory_validation/run_scripts/test_cache_miss.sh
+++ b/test/memory_validation/run_scripts/test_cache_miss.sh
@@ -168,11 +168,11 @@ function one_run
             tccrdmissrate=$(awk -v mr=$missTccRds -v rd=$totTccRds \
                             'BEGIN{printf("%f", mr/rd)}')
 
-            coldmisses=`echo "scale=0; $N/$line" | bc`
+            coldmisses=$(awk -v n=$N -v l=$line 'BEGIN{printf("%.0f", n/l)}')
 
             expectedMissTccRds=$coldmisses
-            if (( $(echo "$tccrdmissrate > 0.98" | bc -l) )) \
-                    && (( $(echo "$tcprdmissrate > 0.98" | bc -l) )); then
+            if (( $(awk 'BEGIN {print "'$tccrdmissrate'" > 0.98}') )) \
+                && (( $(awk 'BEGIN {print "'$tcprdmissrate'" > 0.98}') )); then
                 expectedMissTccRds=$totTcpRds
                 printf "\n\tTCC-READ  : expected=%6s±%s, profiled=%6s, " \
                     $expectedMissTccRds ".5%" $missTccRds
@@ -183,9 +183,9 @@ function one_run
 
             # absolute difference between profiled and expected
             diff=$(( $missTccRds - $coldmisses ))
-            if (( $(echo "$diff < 0" | bc -l) )); then
-                diff=`echo "$diff*-1" | bc -l`; fi
-            if (( $(echo "$tccrdmissrate > 0.98" | bc -l) )); then
+            if (( $(awk 'BEGIN {print "'$diff'" < 0}') )); then
+                diff=$(awk -v d=$diff 'BEGIN{printf("%f", d*-1)}'); fi
+            if (( $(awk 'BEGIN {print "'$tccrdmissrate'" > 0.98}') )); then
               printf "test [${GREEN}PASS${NC}]"
             elif (( $diff < $REQ_DIFF )); then
               printf "test [${GREEN}PASS${NC}]"
@@ -217,10 +217,10 @@ function one_run
             tccwrmissrate=$(awk -v mw=$missTccWrs -v wr=$totTccWrs \
                             'BEGIN{printf("%f", mw/wr)}')
 
-            coldmisses=`echo "scale=0; $N/$line" | bc`
+            coldmisses=$(awk -v n=$N -v l=$line 'BEGIN{printf("%.0f", n/l)}')
 
             expectedMissTccWrs=$coldmisses
-            if (( $(echo "$tccwrmissrate > 0.98" | bc -l) )); then
+            if (( $(awk 'BEGIN {print "'$tccwrmissrate'" > 0.98}') )); then
                 expectedMissTccWrs=$totTcpWrs;
                 printf "\n\tTCC-WRITE : expected=%6s±%s, profiled=%6s, " \
                         $expectedMissTccWrs ".5%" $missTccWrs
@@ -231,7 +231,7 @@ function one_run
             if (($missTccWrs - $coldmisses < $REQ_DIFF)) \
                     && (($missTccWrs - $coldmisses < $REQ_DIFF)); then
               printf "test [${GREEN}PASS${NC}]"
-            elif (( $(echo "$tccwrmissrate > 0.98" | bc -l) )); then
+            elif (( $(awk 'BEGIN {print "'$tccwrmissrate'" > 0.98}') )); then
               printf "test [${GREEN}PASS${NC}]"
             else printf "test [${RED}FAIL${NC}]"; fi
           fi
diff --git a/test/memory_validation/run_scripts/test_fetchwrite_size.sh b/test/memory_validation/run_scripts/test_fetchwrite_size.sh
index bb8a757abe..1aef91afc0 100755
--- a/test/memory_validation/run_scripts/test_fetchwrite_size.sh
+++ b/test/memory_validation/run_scripts/test_fetchwrite_size.sh
@@ -80,7 +80,7 @@ function one_run
         rstdiff=1        # check result (0: pass/no-difference, 1: fail)
 
         line=$b_tcp; if (( $s > $b_tcp)); then line=$s; fi
-        coldmisses=`echo "scale=0; $N/$line" | bc`
+        coldmisses=$(awk -v n=$N -v l=$line 'BEGIN{printf("%.0f", n/l)}')
         #-- use kernel 'cache_test_RO' to validate fetch size
         if [[ $kern == cache_test_RO ]]; then
           # program-level expectation: coldmisses*cacheline_size