From 52e7fd148085ecf1669a1623aa7d58edaa481053 Mon Sep 17 00:00:00 2001 From: Shweta Khatri Date: Tue, 17 Sep 2024 15:50:00 -0400 Subject: [PATCH] hsakmt: debug.c: Fix Coverity reported warnings Fix potential memory leak reported by Coverity warnings Change-Id: Iacbaa99be3f4fe7fae5fb6a10bd41dfc34b96059 --- libhsakmt/src/debug.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libhsakmt/src/debug.c b/libhsakmt/src/debug.c index 7b3eecbcd6..c6a318fb6b 100644 --- a/libhsakmt/src/debug.c +++ b/libhsakmt/src/debug.c @@ -532,8 +532,12 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtDebugTrapIoctl(struct kfd_ioctl_dbg_trap_args *arg (void *)args->suspend_queues.queue_array_ptr : (void *)args->resume_queues.queue_array_ptr; - memcpy(queue_ptr, hsakmt_convert_queue_ids(num_queues, Queues), - num_queues * sizeof(uint32_t)); + uint32_t *queue_ids = hsakmt_convert_queue_ids(num_queues, Queues); + if (!queue_ids) { + return HSAKMT_STATUS_NO_MEMORY; + } + memcpy(queue_ptr, queue_ids, num_queues * sizeof(uint32_t)); + free(queue_ids); } long err = hsakmt_ioctl(hsakmt_kfd_fd, AMDKFD_IOC_DBG_TRAP, args);