From 537b3dd67faed63a2e6ba494cf440fffcea2b09b Mon Sep 17 00:00:00 2001
From: pghafari <pghafari@amd.com>
Date: Thu, 29 Sep 2022 00:37:20 -0400
Subject: [PATCH] SWDEV-356570, SWDEV-356571, SWDEV-356572, SWDEV-356575 -

updating with current status of hipNotSupported and null checks

Change-Id: I3b1ce3d3e5ce9b69d1f5dacda35f5aa586714f5c


[ROCm/clr commit: 88c399a43de7f0fa57e53f3fd070432df5409429]
---
 projects/clr/hipamd/src/hip_mempool.cpp | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/projects/clr/hipamd/src/hip_mempool.cpp b/projects/clr/hipamd/src/hip_mempool.cpp
index 312becf4db..8309d19e7c 100644
--- a/projects/clr/hipamd/src/hip_mempool.cpp
+++ b/projects/clr/hipamd/src/hip_mempool.cpp
@@ -239,7 +239,10 @@ hipError_t hipMemPoolExportToShareableHandle(
     hipMemAllocationHandleType handle_type,
     unsigned int               flags) {
   HIP_INIT_API(hipMemPoolExportToShareableHandle, shared_handle, mem_pool, handle_type, flags);
-  HIP_RETURN(hipSuccess);
+  if (mem_pool == nullptr || shared_handle == nullptr || flags == -1) {
+    HIP_RETURN(hipErrorInvalidValue);
+  }
+  HIP_RETURN(hipErrorNotSupported);
 }
 
 // ================================================================================================
@@ -249,13 +252,19 @@ hipError_t hipMemPoolImportFromShareableHandle(
     hipMemAllocationHandleType handle_type,
     unsigned int               flags) {
   HIP_INIT_API(hipMemPoolImportFromShareableHandle, mem_pool, shared_handle, handle_type, flags);
-  HIP_RETURN(hipSuccess);
+  if (mem_pool == nullptr || shared_handle == nullptr || flags == -1) {
+    HIP_RETURN(hipErrorInvalidValue);
+  }
+  HIP_RETURN(hipErrorNotSupported);
 }
 
 // ================================================================================================
 hipError_t hipMemPoolExportPointer(hipMemPoolPtrExportData* export_data, void* ptr) {
   HIP_INIT_API(hipMemPoolExportPointer, export_data, ptr);
-  HIP_RETURN(hipSuccess);
+  if (export_data == nullptr || ptr == nullptr) {
+    HIP_RETURN(hipErrorInvalidValue);
+  }
+  HIP_RETURN(hipErrorNotSupported);
 }
 
 // ================================================================================================
@@ -264,5 +273,9 @@ hipError_t hipMemPoolImportPointer(
     hipMemPool_t             mem_pool,
     hipMemPoolPtrExportData* export_data) {
   HIP_INIT_API(hipMemPoolImportPointer, ptr, mem_pool, export_data);
-  HIP_RETURN(hipSuccess);
+  if (mem_pool == nullptr || export_data == nullptr || ptr == nullptr) {
+    HIP_RETURN(hipErrorInvalidValue);
+  }
+
+  HIP_RETURN(hipErrorNotSupported);
 }