AI/rocm-systems
2
0
Vork 0
Code Kwesties Pull-aanvragen Actions Paketten Projecten Publicaties Wiki Activiteit

[SWDEV-558534] AMD-SMI bad pages add flag to convert to hex (#1900)

Bladeren bron 
* Simplify hex flag check for bad page info
* moved the hex help text up with the other help text

---------

Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Authored-by: Koushik Billakanti <Koushik.Billakanti@amd.com>
Co-authored-by: Koushik Billakanti <Koushik.Billakanti@amd.com>
This commit is contained in:
systems-assistant[bot]
2026-01-08 10:21:10 -06:00
gecommit door GitHub
bovenliggende 8326c33d33
commit 53c56fca5f
2 gewijzigde bestanden met toevoegingen van 27 en 7 verwijderingen
Download Patch-bestand Download Diff-bestand Expand all files Collapse all files
projects/amdsmi/amdsmi_cli/amdsmi_commands.py
+25 -7
Bestand weergeven
@@ -1431,7 +1431,7 @@ class AMDSMICommands():
self.logger.print_output(multiple_device_enabled=multiple_devices_csv_override)
def bad_pages(self, args, multiple_devices=False, gpu=None, retired=None, pending=None, un_res=None):
def bad_pages(self, args, multiple_devices=False, gpu=None, retired=None, pending=None, un_res=None, hex_format=None):
""" Get bad pages information for target gpu
Args:
@@ -1441,6 +1441,7 @@ class AMDSMICommands():
retired (bool, optional) - Value override for args.retired
pending (bool, optional) - Value override for args.pending/
un_res (bool, optional) - Value override for args.un_res
hex_format (bool, optional) - Value override for args.hex
Raises:
IndexError: Index error if gpu list is empty
@@ -1457,6 +1458,8 @@ class AMDSMICommands():
args.pending = pending
if un_res:
args.un_res = un_res
if hex_format is not None:
args.hex = hex_format
# Handle No GPU passed
if args.gpu == None:
@@ -1500,8 +1503,13 @@ class AMDSMICommands():
for bad_page in bad_page_info:
if bad_page["status"] == amdsmi_interface.AmdSmiMemoryPageStatus.RESERVED:
bad_page_info_entry = {}
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
# Format page address and size based on --hex flag
if args.hex:
bad_page_info_entry["page_address"] = f"0x{bad_page['page_address']:x}"
bad_page_info_entry["page_size"] = f"0x{bad_page['page_size']:x}"
else:
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
status_string = amdsmi_interface.amdsmi_wrapper.amdsmi_memory_page_status_t__enumvalues[bad_page["status"]]
bad_page_info_entry["status"] = status_string.replace("AMDSMI_MEM_PAGE_STATUS_", "")
bad_page_info_output.append(bad_page_info_entry)
@@ -1522,8 +1530,13 @@ class AMDSMICommands():
for bad_page in bad_page_info:
if bad_page["status"] == amdsmi_interface.AmdSmiMemoryPageStatus.PENDING:
bad_page_info_entry = {}
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
# Format page address and size based on --hex flag
if args.hex:
bad_page_info_entry["page_address"] = f"0x{bad_page['page_address']:x}"
bad_page_info_entry["page_size"] = f"0x{bad_page['page_size']:x}"
else:
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
status_string = amdsmi_interface.amdsmi_wrapper.amdsmi_memory_page_status_t__enumvalues[bad_page["status"]]
bad_page_info_entry["status"] = status_string.replace("AMDSMI_MEM_PAGE_STATUS_", "")
bad_page_info_output.append(bad_page_info_entry)
@@ -1544,8 +1557,13 @@ class AMDSMICommands():
for bad_page in bad_page_info:
if bad_page["status"] == amdsmi_interface.AmdSmiMemoryPageStatus.UNRESERVABLE:
bad_page_info_entry = {}
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
# Format page address and size based on --hex flag
if hasattr(args, 'hex') and args.hex:
bad_page_info_entry["page_address"] = f"0x{bad_page['page_address']:x}"
bad_page_info_entry["page_size"] = f"0x{bad_page['page_size']:x}"
else:
bad_page_info_entry["page_address"] = bad_page["page_address"]
bad_page_info_entry["page_size"] = bad_page["page_size"]
status_string = amdsmi_interface.amdsmi_wrapper.amdsmi_memory_page_status_t__enumvalues[bad_page["status"]]
bad_page_info_entry["status"] = status_string.replace("AMDSMI_MEM_PAGE_STATUS_", "")
bad_page_info_output.append(bad_page_info_entry)
projects/amdsmi/amdsmi_cli/amdsmi_parser.py
+2
Bestand weergeven
@@ -1019,6 +1019,7 @@ class AMDSMIParser(argparse.ArgumentParser):
pending_help = "Displays all pending retired pages"
retired_help = "Displays retired pages"
un_res_help = "Displays unreservable pages"
hex_help = "Displays page addresses and sizes in hexadecimal format"
# Create bad_pages subparser
bad_pages_parser = subparsers.add_parser('bad-pages', help=bad_pages_help, description=bad_pages_subcommand_help)
@@ -1030,6 +1031,7 @@ class AMDSMIParser(argparse.ArgumentParser):
bad_pages_parser.add_argument('-p', '--pending', action='store_true', required=False, help=pending_help)
bad_pages_parser.add_argument('-r', '--retired', action='store_true', required=False, help=retired_help)
bad_pages_parser.add_argument('-u', '--un-res', action='store_true', required=False, help=un_res_help)
bad_pages_parser.add_argument('-x', '--hex', action='store_true', required=False, help=hex_help)
# Add Universal Arguments
self._add_device_arguments(bad_pages_parser, required=False)