Fixing Clang tidy errors (#195)

* Fixing Clang tidy errors

* format-fix

* Update code_object.hpp

* Clang Tidy Fixes on the whole Source folder

* Update source/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Addressing reviews

* Correcting the logic for parsing att counters

* Format Fix

* Update source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-att/tests/standalone_tool_main.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-tool/config.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Formatting

* Deactivate clang-tidy in source/lib/rocprofiler-sdk-att/tests

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

source/lib/rocprofiler-sdk-att/waitcnt/tests/att_decoder_waitcnt_test.cpp

@@ -93,14 +93,14 @@ TEST(att_decoder_waitcnt_test, gfx9)
     wave.instructions_array = insts.data();
     wave.instructions_size  = insts.size();
 
-    auto& data = WaitcntList::Get(9, wave, isa_map);
+    const auto& data = WaitcntList::Get(9, wave, isa_map);
 
     std::map<int, std::set<int>> dependencies{};
 
-    for(auto& [dst, src] : data.mem_unroll)
+    for(const auto& [dst, src] : data.mem_unroll)
     {
         auto& dep = dependencies[dst];
-        for(auto& p : src)
+        for(const auto& p : src)
             dep.insert(p);
     }
 
@@ -183,14 +183,14 @@ TEST(att_decoder_waitcnt_test, gfx10)
     wave.instructions_array = insts.data();
     wave.instructions_size  = insts.size();
 
-    auto& data = WaitcntList::Get(10, wave, isa_map);
+    const auto& data = WaitcntList::Get(10, wave, isa_map);
 
     std::map<int, std::set<int>> dependencies{};
 
-    for(auto& [dst, src] : data.mem_unroll)
+    for(const auto& [dst, src] : data.mem_unroll)
     {
         auto& dep = dependencies[dst];
-        for(auto& p : src)
+        for(const auto& p : src)
             dep.insert(p);
     }
 
@@ -300,14 +300,14 @@ TEST(att_decoder_waitcnt_test, gfx12)
     wave.instructions_array = insts.data();
     wave.instructions_size  = insts.size();
 
-    auto& data = WaitcntList::Get(12, wave, isa_map);
+    const auto& data = WaitcntList::Get(12, wave, isa_map);
 
     std::map<int, std::set<int>> dependencies{};
 
-    for(auto& [dst, src] : data.mem_unroll)
+    for(const auto& [dst, src] : data.mem_unroll)
     {
         auto& dep = dependencies[dst];
-        for(auto& p : src)
+        for(const auto& p : src)
             dep.insert(p);
     }