Fixing Clang tidy errors (#195)

* Fixing Clang tidy errors

* format-fix

* Update code_object.hpp

* Clang Tidy Fixes on the whole Source folder

* Update source/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Addressing reviews

* Correcting the logic for parsing att counters

* Format Fix

* Update source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-att/tests/standalone_tool_main.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-tool/config.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Formatting

* Deactivate clang-tidy in source/lib/rocprofiler-sdk-att/tests

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

source/lib/rocprofiler-sdk-tool/config.cpp

@@ -163,8 +163,7 @@ parse_att_counters(std::string line)
     handle_special_chars(line);
 
     auto extract_counter_name_and_simd_mask = [](std::string& input) {
-        std::string counter_name = "";
-        auto        ret          = att_perfcounter{};
+        auto ret = att_perfcounter{};
 
         size_t pos = input.find(':');
 
@@ -174,7 +173,9 @@ parse_att_counters(std::string line)
             ret.simd_mask    = std::stoi(input.substr(pos + 1), nullptr, 16);
         }
         else
-            counter_name = input;
+        {
+            ret.counter_name = input;
+        }
         return ret;
     };