diff --git a/cmake/Templates/rocprofiler-sdk/build-config.cmake.in b/cmake/Templates/rocprofiler-sdk/build-config.cmake.in index b13aeb667d..ba316cadad 100644 --- a/cmake/Templates/rocprofiler-sdk/build-config.cmake.in +++ b/cmake/Templates/rocprofiler-sdk/build-config.cmake.in @@ -7,19 +7,19 @@ if(@PACKAGE_NAME@_FIND_COMPONENTS) if(TARGET ${TARG}) set(@PACKAGE_NAME@_${COMP}_FOUND 1) list(APPEND @PACKAGE_NAME@_LIBRARIES ${TARG}) - target_link_libraries(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE ${TARG}) + target_link_libraries(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE ${TARG}) else() set(@PACKAGE_NAME@_${COMP}_FOUND 0) endif() endforeach() else() - set(@PACKAGE_NAME@_LIBRARIES @PROJECT_NAME@::@PROJECT_NAME@) + set(@PACKAGE_NAME@_LIBRARIES @PACKAGE_NAME@::@PACKAGE_NAME@) endif() foreach(COMP @PROJECT_BUILD_TREE_TARGETS@) set(TARG @PROJECT_NAME@::@PROJECT_NAME@-${COMP}) if(TARGET ${TARG}) list(APPEND @PACKAGE_NAME@_LIBRARIES ${TARG}) - target_link_libraries(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE ${TARG}) + target_link_libraries(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE ${TARG}) endif() endforeach() diff --git a/cmake/Templates/rocprofiler-sdk/config.cmake.in b/cmake/Templates/rocprofiler-sdk/config.cmake.in index eba09ad26c..5967730ce0 100644 --- a/cmake/Templates/rocprofiler-sdk/config.cmake.in +++ b/cmake/Templates/rocprofiler-sdk/config.cmake.in @@ -34,12 +34,14 @@ endforeach() set(@PACKAGE_NAME@_LIBRARIES) # add interface library -add_library(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE IMPORTED) -add_library(@PACKAGE_NAME@::@PACKAGE_NAME@ ALIAS @PROJECT_NAME@::@PROJECT_NAME@) +add_library(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE IMPORTED) +if(NOT TARGET @PROJECT_NAME@::@PROJECT_NAME@) + add_library(@PROJECT_NAME@::@PROJECT_NAME@ ALIAS @PACKAGE_NAME@::@PACKAGE_NAME@) +endif() -target_include_directories(@PROJECT_NAME@::@PROJECT_NAME@ +target_include_directories(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE "${@PACKAGE_NAME@_INCLUDE_DIR}") -target_link_directories(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE +target_link_directories(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE "${@PACKAGE_NAME@_LIB_DIR}") if(@PACKAGE_NAME@_BUILD_TREE @@ -111,7 +113,7 @@ else() set(TARG @PROJECT_NAME@::@PROJECT_NAME@-${TARG}) if(NOT @PACKAGE_NAME@_FIND_COMPONENTS) list(APPEND @PACKAGE_NAME@_LIBRARIES ${TARG}) - target_link_libraries(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE ${TARG}) + target_link_libraries(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE ${TARG}) endif() endforeach() @@ -121,14 +123,14 @@ else() if(TARGET ${TARG}) set(@PACKAGE_NAME@_${COMP}_FOUND 1) list(APPEND @PACKAGE_NAME@_LIBRARIES ${TARG}) - target_link_libraries(@PROJECT_NAME@::@PROJECT_NAME@ INTERFACE ${TARG}) + target_link_libraries(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE ${TARG}) else() set(@PACKAGE_NAME@_${COMP}_FOUND 0) endif() endforeach() endif() - target_link_libraries(@PROJECT_NAME@::@PROJECT_NAME@ + target_link_libraries(@PACKAGE_NAME@::@PACKAGE_NAME@ INTERFACE @PACKAGE_NAME@::@PACKAGE_NAME@-external-nolink) endif() diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index 0289cce2ee..b52bf2009f 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -76,7 +76,7 @@ if(ROCPROFILER_BUILD_GLOG) # May want to use GFLAGS in the future set(WITH_GFLAGS OFF) set(WITH_GTEST OFF) - set(WITH_UNWIND OFF) + set(WITH_UNWIND "none") add_subdirectory(glog EXCLUDE_FROM_ALL) target_link_libraries(rocprofiler-glog INTERFACE $) diff --git a/samples/advanced_thread_trace/CMakeLists.txt b/samples/advanced_thread_trace/CMakeLists.txt index 14c0ada5b3..76f1ae536a 100644 --- a/samples/advanced_thread_trace/CMakeLists.txt +++ b/samples/advanced_thread_trace/CMakeLists.txt @@ -46,8 +46,8 @@ add_executable(advanced-thread-trace) target_sources(advanced-thread-trace PRIVATE main.cpp client.cpp) target_link_libraries( advanced-thread-trace - PRIVATE rocprofiler::rocprofiler amd_comgr rocprofiler::samples-common-library - rocprofiler::samples-build-flags) + PRIVATE rocprofiler-sdk::rocprofiler-sdk amd_comgr + rocprofiler::samples-common-library rocprofiler::samples-build-flags) rocprofiler_samples_get_preload_env(PRELOAD_ENV advanced-thread-trace) diff --git a/samples/code_object_isa_decode/CMakeLists.txt b/samples/code_object_isa_decode/CMakeLists.txt index 90553bf9d8..9f7558dbe9 100644 --- a/samples/code_object_isa_decode/CMakeLists.txt +++ b/samples/code_object_isa_decode/CMakeLists.txt @@ -103,8 +103,8 @@ add_executable(code-object-isa-decode) target_sources(code-object-isa-decode PRIVATE main.cpp client.cpp) target_link_libraries( code-object-isa-decode - PRIVATE rocprofiler::samples-common-library rocprofiler::rocprofiler amd_comgr - rocprofiler::samples-build-flags) + PRIVATE rocprofiler::samples-common-library rocprofiler-sdk::rocprofiler-sdk + amd_comgr rocprofiler::samples-build-flags) rocprofiler_samples_get_preload_env(PRELOAD_ENV code-object-isa-decode) diff --git a/source/include/rocprofiler-sdk/cxx/serialization.hpp b/source/include/rocprofiler-sdk/cxx/serialization.hpp index 4fd458db22..07067d8e10 100644 --- a/source/include/rocprofiler-sdk/cxx/serialization.hpp +++ b/source/include/rocprofiler-sdk/cxx/serialization.hpp @@ -71,8 +71,18 @@ ar(make_nvp(NAME, _val)); \ } -namespace cereal -{ +#if !defined(ROCPROFILER_SDK_CEREAL_NAMESPACE_BEGIN) +# define ROCPROFILER_SDK_CEREAL_NAMESPACE_BEGIN \ + namespace cereal \ + { +#endif + +#if !defined(ROCPROFILER_SDK_CEREAL_NAMESPACE_END) +# define ROCPROFILER_SDK_CEREAL_NAMESPACE_END } // namespace cereal +#endif + +ROCPROFILER_SDK_CEREAL_NAMESPACE_BEGIN + template void save(ArchiveT& ar, rocprofiler_context_id_t data) @@ -781,7 +791,8 @@ save(ArchiveT& ar, const rocprofiler::sdk::utility::name_info_impl) _info.callback_domain_idx, _info.buffered_domain_idx, _info.operation_idx)) return; - ROCP_INFO << "updating table entry for " << _info.name; + ROCP_TRACE << "updating table entry for " << _info.name; // 1. get the sub-table containing the function pointer in original table // 2. get reference to function pointer in sub-table in original table diff --git a/source/lib/rocprofiler-sdk/hsa/async_copy.cpp b/source/lib/rocprofiler-sdk/hsa/async_copy.cpp index 67ff00c1ad..5160c3eb7a 100644 --- a/source/lib/rocprofiler-sdk/hsa/async_copy.cpp +++ b/source/lib/rocprofiler-sdk/hsa/async_copy.cpp @@ -749,13 +749,13 @@ async_copy_save(hsa_amd_ext_table_t* _orig, uint64_t _tbl_instance) if(!_copy_func) { - ROCP_INFO << "copying table entry for " << _meta.name; + ROCP_TRACE << "copying table entry for " << _meta.name; _copy_func = _orig_func; } else { - ROCP_INFO << "skipping copying table entry for " << _meta.name << " from table instance " - << _tbl_instance; + ROCP_TRACE << "skipping copying table entry for " << _meta.name << " from table instance " + << _tbl_instance; } } diff --git a/source/lib/rocprofiler-sdk/hsa/hsa.cpp b/source/lib/rocprofiler-sdk/hsa/hsa.cpp index 9785271870..9381192ffd 100644 --- a/source/lib/rocprofiler-sdk/hsa/hsa.cpp +++ b/source/lib/rocprofiler-sdk/hsa/hsa.cpp @@ -565,13 +565,13 @@ copy_table(Tp* _orig, uint64_t _tbl_instance, std::integral_constant{}; auto& _table = _meta.get_table(_orig); diff --git a/source/lib/rocprofiler-sdk/marker/marker.cpp b/source/lib/rocprofiler-sdk/marker/marker.cpp index 2877974bdc..6a6de2bcaa 100644 --- a/source/lib/rocprofiler-sdk/marker/marker.cpp +++ b/source/lib/rocprofiler-sdk/marker/marker.cpp @@ -393,13 +393,13 @@ copy_table(Tp* _orig, uint64_t _tbl_instance, std::integral_constant) _info.callback_domain_idx, _info.buffered_domain_idx, _info.operation_idx)) return; - ROCP_INFO << "updating table entry for " << _info.name; + ROCP_TRACE << "updating table entry for " << _info.name; // 1. get the sub-table containing the function pointer in original table // 2. get reference to function pointer in sub-table in original table diff --git a/tests/bin/hsa-queue-dependency/CMakeLists.txt b/tests/bin/hsa-queue-dependency/CMakeLists.txt index 8861845fd3..3d90ad2007 100644 --- a/tests/bin/hsa-queue-dependency/CMakeLists.txt +++ b/tests/bin/hsa-queue-dependency/CMakeLists.txt @@ -68,7 +68,7 @@ find_package( target_link_libraries(multiqueue_testapp PRIVATE amd_comgr) find_package(rocprofiler-sdk REQUIRED) -target_link_libraries(multiqueue_testapp PRIVATE rocprofiler::rocprofiler +target_link_libraries(multiqueue_testapp PRIVATE rocprofiler-sdk::rocprofiler-sdk rocprofiler::tests-common-library) find_package( diff --git a/tests/thread-trace/CMakeLists.txt b/tests/thread-trace/CMakeLists.txt index d2461ca143..70d38730dd 100644 --- a/tests/thread-trace/CMakeLists.txt +++ b/tests/thread-trace/CMakeLists.txt @@ -115,8 +115,8 @@ add_executable(thread-trace-api-single-test) target_sources( thread-trace-api-single-test PRIVATE main.cpp trace_callbacks.cpp single_dispatch.cpp kernel_branch.cpp kernel_lds.cpp) -target_link_libraries(thread-trace-api-single-test PRIVATE rocprofiler::rocprofiler - amd_comgr dw) +target_link_libraries(thread-trace-api-single-test + PRIVATE rocprofiler-sdk::rocprofiler-sdk amd_comgr dw) if(ROCPROFILER_MEMCHECK_PRELOAD_ENV) set(PRELOAD_ENV @@ -138,7 +138,7 @@ add_executable(thread-trace-api-multi-test) target_sources( thread-trace-api-multi-test PRIVATE main.cpp trace_callbacks.cpp multi_dispatch.cpp kernel_branch.cpp kernel_lds.cpp) -target_link_libraries(thread-trace-api-multi-test PRIVATE rocprofiler::rocprofiler +target_link_libraries(thread-trace-api-multi-test PRIVATE rocprofiler-sdk::rocprofiler-sdk amd_comgr dw) if(ROCPROFILER_MEMCHECK_PRELOAD_ENV) diff --git a/tests/tools/CMakeLists.txt b/tests/tools/CMakeLists.txt index 03890cd2f7..cb31bb4a7f 100644 --- a/tests/tools/CMakeLists.txt +++ b/tests/tools/CMakeLists.txt @@ -15,7 +15,7 @@ add_library(rocprofiler-sdk-json-tool SHARED) target_sources(rocprofiler-sdk-json-tool PRIVATE json-tool.cpp) target_link_libraries( rocprofiler-sdk-json-tool - PRIVATE rocprofiler::rocprofiler rocprofiler::rocprofiler-cereal + PRIVATE rocprofiler-sdk::rocprofiler-sdk rocprofiler::rocprofiler-cereal rocprofiler::tests-build-flags rocprofiler::tests-common-library rocprofiler::tests-perfetto) set_target_properties( @@ -29,7 +29,7 @@ set_target_properties( # tool library which just checks that tools can be compiled with C language add_library(rocprofiler-sdk-c-tool SHARED) target_sources(rocprofiler-sdk-c-tool PRIVATE c-tool.c) -target_link_libraries(rocprofiler-sdk-c-tool PRIVATE rocprofiler::rocprofiler +target_link_libraries(rocprofiler-sdk-c-tool PRIVATE rocprofiler-sdk::rocprofiler-sdk rocprofiler::tests-build-flags) set_target_properties( rocprofiler-sdk-c-tool