From 593fdf6c27d49313150e1f32d5c0dc19b1b9df99 Mon Sep 17 00:00:00 2001 From: "Madsen, Jonathan" Date: Fri, 16 May 2025 11:33:46 -0500 Subject: [PATCH] [CI] Disable page-migration tests (#396) * Disable page-migration tests * Account for gfx hexadecimal characters * Update continuous integration action - remove test exclude for test-page-migration since test is disabled at cmake level * Fix internal ctest error --------- Co-authored-by: Jonathan R. Madsen [ROCm/rocprofiler-sdk commit: 3eb921a34c52530090f8a998a81bef33a8faebdf] --- .../.github/workflows/continuous_integration.yml | 14 +++++++------- .../rocprofiler-sdk/tests/common/CMakeLists.txt | 1 + .../tests/page-migration/CMakeLists.txt | 15 +++++++++++---- 3 files changed, 19 insertions(+), 11 deletions(-) diff --git a/projects/rocprofiler-sdk/.github/workflows/continuous_integration.yml b/projects/rocprofiler-sdk/.github/workflows/continuous_integration.yml index 64499d8a7b..a788feba4d 100644 --- a/projects/rocprofiler-sdk/.github/workflows/continuous_integration.yml +++ b/projects/rocprofiler-sdk/.github/workflows/continuous_integration.yml @@ -23,13 +23,13 @@ env: ROCM_PATH: "/opt/rocm" GPU_TARGETS: "gfx900 gfx906 gfx908 gfx90a gfx940 gfx941 gfx942 gfx1030 gfx1100 gfx1101 gfx1102 gfx1201" PATH: "/usr/bin:$PATH" - navi3_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" - vega20_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" - mi200_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" - mi300_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" - mi300a_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" - mi325_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate)|counter-collection-buffer)$" - navi4_EXCLUDE_TESTS_REGEX: "^(test-page-migration-(execute|validate))$" + navi3_EXCLUDE_TESTS_REGEX: "" + vega20_EXCLUDE_TESTS_REGEX: "" + mi200_EXCLUDE_TESTS_REGEX: "" + mi300_EXCLUDE_TESTS_REGEX: "" + mi300a_EXCLUDE_TESTS_REGEX: "" + mi325_EXCLUDE_TESTS_REGEX: "^(counter-collection-buffer)$" + navi4_EXCLUDE_TESTS_REGEX: "" navi3_EXCLUDE_LABEL_REGEX: "^(pc-sampling)$" vega20_EXCLUDE_LABEL_REGEX: "^(pc-sampling)$" mi200_EXCLUDE_LABEL_REGEX: "^(stochastic)$" diff --git a/projects/rocprofiler-sdk/tests/common/CMakeLists.txt b/projects/rocprofiler-sdk/tests/common/CMakeLists.txt index dba1347c73..3969c12129 100644 --- a/projects/rocprofiler-sdk/tests/common/CMakeLists.txt +++ b/projects/rocprofiler-sdk/tests/common/CMakeLists.txt @@ -40,6 +40,7 @@ endif() if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.30) cmake_policy(SET CMP0167 NEW) + cmake_policy(SET CMP0169 OLD) endif() find_package(rocprofiler-sdk REQUIRED) diff --git a/projects/rocprofiler-sdk/tests/page-migration/CMakeLists.txt b/projects/rocprofiler-sdk/tests/page-migration/CMakeLists.txt index c09d4131d8..154c419d86 100644 --- a/projects/rocprofiler-sdk/tests/page-migration/CMakeLists.txt +++ b/projects/rocprofiler-sdk/tests/page-migration/CMakeLists.txt @@ -17,6 +17,13 @@ else() set(PRELOAD_ENV "LD_PRELOAD=$") endif() +list(GET rocprofiler-sdk-tests-gfx-info 0 page-migration-gpu-0-gfx-info) + +# disabled on all architectures +if("${page-migration-gpu-0-gfx-info}" MATCHES "^gfx([0-9a-fA-F]+)$") + set(IS_DISABLED ON) +endif() + add_test(NAME test-page-migration-execute COMMAND $ 4 1024) set(page-migration-env @@ -40,8 +47,8 @@ set_tests_properties( "KFD does not support SVM event reporting" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} - ATTACHED_FILES - ${CMAKE_CURRENT_BINARY_DIR}/page-migration-test.json) + DISABLED + "${IS_DISABLED}") # copy to binary directory rocprofiler_configure_pytest_files(COPY validate.py conftest.py CONFIG pytest.ini) @@ -64,5 +71,5 @@ set_tests_properties( "KFD does not support SVM event reporting" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} - ATTACHED_FILES - ${CMAKE_CURRENT_BINARY_DIR}/page-migration-test.json) + DISABLED + "${IS_DISABLED}")