rdc_field_t replaces uint32_t; centralize field data

Make the RDC use the new rdc_field_t enum instead of uint32_t.
This will help prevent invalid field types from being passed in.

Also, centralize where data related to fields is kept. This will
reduce the number of places where changes are required each
time a new field is added.

Finally, cleaned up several cpplint issues.

Change-Id: I48e4512e18c164411d8b09ae3d4bed99fba359ec

include/rdc_lib/impl/RdcEmbeddedHandler.h

@@ -19,8 +19,8 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 */
-#ifndef RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_
-#define RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_
+#ifndef INCLUDE_RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_
+#define INCLUDE_RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_
 
 #include <future>  // NOLINT(build/c++11)
 #include "rdc_lib/RdcHandler.h"
@@ -57,7 +57,7 @@ class RdcEmbeddedHandler: public RdcHandler {
     rdc_status_t rdc_group_gpu_add(rdc_gpu_group_t groupId,
                 uint32_t gpu_index) override;
     rdc_status_t rdc_group_field_create(uint32_t num_field_ids,
-        uint32_t* field_ids, const char* field_group_name,
+        rdc_field_t* field_ids, const char* field_group_name,
         rdc_field_grp_t* rdc_field_group_id) override;
     rdc_status_t rdc_group_field_get_info(
         rdc_field_grp_t rdc_field_group_id,
@@ -78,9 +78,9 @@ class RdcEmbeddedHandler: public RdcHandler {
         rdc_field_grp_t field_group_id, uint64_t update_freq,
         double max_keep_age, uint32_t max_keep_samples) override;
     rdc_status_t rdc_field_get_latest_value(uint32_t gpu_index,
-        uint32_t field, rdc_field_value* value) override;
+        rdc_field_t field, rdc_field_value* value) override;
     rdc_status_t rdc_field_get_value_since(uint32_t gpu_index,
-        uint32_t field, uint64_t since_time_stamp,
+        rdc_field_t field, uint64_t since_time_stamp,
         uint64_t *next_since_time_stamp, rdc_field_value* value) override;
     rdc_status_t rdc_field_unwatch(rdc_gpu_group_t group_id,
         rdc_field_grp_t field_group_id) override;
@@ -108,4 +108,4 @@ extern "C" {
     amd::rdc::RdcHandler *make_handler(rdc_operation_mode_t op_mode);
 }
 
-#endif  // RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_
+#endif  // INCLUDE_RDC_LIB_IMPL_RDCEMBEDDEDHANDLER_H_