rdc_field_t replaces uint32_t; centralize field data

Make the RDC use the new rdc_field_t enum instead of uint32_t.
This will help prevent invalid field types from being passed in.

Also, centralize where data related to fields is kept. This will
reduce the number of places where changes are required each
time a new field is added.

Finally, cleaned up several cpplint issues.

Change-Id: I48e4512e18c164411d8b09ae3d4bed99fba359ec

include/rdc_lib/impl/RdcGroupSettingsImpl.h

@@ -19,9 +19,8 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 */
-#ifndef RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_
-#define RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_
-
+#ifndef INCLUDE_RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_
+#define INCLUDE_RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_
 
 #include <memory>
 #include <map>
@@ -46,7 +45,7 @@ class RdcGroupSettingsImpl: public RdcGroupSettings {
         rdc_gpu_group_t group_id_list[], uint32_t* count) override;
 
       rdc_status_t rdc_group_field_create(uint32_t num_field_ids,
-        uint32_t* field_ids, const char* field_group_name,
+          rdc_field_t* field_ids, const char* field_group_name,
         rdc_field_grp_t* rdc_field_group_id) override;
       rdc_status_t rdc_group_field_destroy(
         rdc_field_grp_t rdc_field_group_id) override;
@@ -71,4 +70,4 @@ class RdcGroupSettingsImpl: public RdcGroupSettings {
 }  // namespace amd
 
 
-#endif  // RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_
+#endif  // INCLUDE_RDC_LIB_IMPL_RDCGROUPSETTINGSIMPL_H_