AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rdc_field_t replaces uint32_t; centralize field data

Browse Source 
Make the RDC use the new rdc_field_t enum instead of uint32_t.
This will help prevent invalid field types from being passed in.

Also, centralize where data related to fields is kept. This will
reduce the number of places where changes are required each
time a new field is added.

Finally, cleaned up several cpplint issues.

Change-Id: I48e4512e18c164411d8b09ae3d4bed99fba359ec
This commit is contained in:
Chris Freehill
2020-07-24 19:40:48 -05:00
parent e6d910f67a
commit 5950ebadc4
43 changed files with 459 additions and 388 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rdc_libs/rdc_client/src/RdcStandaloneHandler.cc
+7 -6
View File
@@ -290,7 +290,7 @@ rdc_status_t RdcStandaloneHandler::rdc_group_gpu_add(rdc_gpu_group_t group_id,
}
rdc_status_t RdcStandaloneHandler::rdc_group_field_create(
uint32_t num_field_ids, uint32_t* field_ids,
uint32_t num_field_ids, rdc_field_t* field_ids,
const char* field_group_name, rdc_field_grp_t* rdc_field_group_id) {
if (!field_ids || !field_group_name || !rdc_field_group_id) {
return RDC_ST_BAD_PARAMETER;
@@ -339,7 +339,8 @@ rdc_status_t RdcStandaloneHandler::rdc_group_field_get_info(
strncpy_with_null(field_group_info->group_name,
reply.filed_group_name().c_str(), RDC_MAX_STR_LENGTH);
for (int i = 0; i < reply.field_ids_size(); i++) {
field_group_info->field_ids[i] = reply.field_ids(i);
field_group_info->field_ids[i] =
static_cast<rdc_field_t>(reply.field_ids(i));
}
return RDC_ST_OK;
@@ -471,7 +472,7 @@ rdc_status_t RdcStandaloneHandler::rdc_field_watch(rdc_gpu_group_t group_id,
}
rdc_status_t RdcStandaloneHandler::rdc_field_get_latest_value(
uint32_t gpu_index, uint32_t field, rdc_field_value* value) {
uint32_t gpu_index, rdc_field_t field, rdc_field_value* value) {
if (!value) {
return RDC_ST_BAD_PARAMETER;
}
@@ -487,7 +488,7 @@ rdc_status_t RdcStandaloneHandler::rdc_field_get_latest_value(
rdc_status_t err_status = error_handle(status, reply.status());
if (err_status != RDC_ST_OK) return err_status;
value->field_id = reply.field_id();
value->field_id = static_cast<rdc_field_t>(reply.field_id());
value->status = reply.rdc_status();
value->ts = reply.ts();
value->type = static_cast<rdc_field_type_t>(reply.type());
@@ -504,7 +505,7 @@ rdc_status_t RdcStandaloneHandler::rdc_field_get_latest_value(
}
rdc_status_t RdcStandaloneHandler::rdc_field_get_value_since(uint32_t gpu_index,
uint32_t field, uint64_t since_time_stamp,
rdc_field_t field, uint64_t since_time_stamp,
uint64_t *next_since_time_stamp, rdc_field_value* value) {
if (!next_since_time_stamp || !value) {
return RDC_ST_BAD_PARAMETER;
@@ -522,7 +523,7 @@ rdc_status_t RdcStandaloneHandler::rdc_field_get_value_since(uint32_t gpu_index,
rdc_status_t err_status = error_handle(status, reply.status());
if (err_status != RDC_ST_OK) return err_status;
value->field_id = reply.field_id();
value->field_id = static_cast<rdc_field_t>(reply.field_id());
value->status = reply.rdc_status();
value->ts = reply.ts();
value->type = static_cast<rdc_field_type_t>(reply.type());