rdc_field_t replaces uint32_t; centralize field data

Make the RDC use the new rdc_field_t enum instead of uint32_t.
This will help prevent invalid field types from being passed in.

Also, centralize where data related to fields is kept. This will
reduce the number of places where changes are required each
time a new field is added.

Finally, cleaned up several cpplint issues.

Change-Id: I48e4512e18c164411d8b09ae3d4bed99fba359ec
This commit is contained in:
Chris Freehill
2020-07-24 19:40:48 -05:00
parent e6d910f67a
commit 5950ebadc4
43 changed files with 459 additions and 388 deletions
+1 -1
View File
@@ -61,7 +61,7 @@ class RdciDmonSubSystem: public RdciSubSystem {
};
std::map<OPTIONS, uint32_t> options_;
std::vector<uint32_t> field_ids_;
std::vector<rdc_field_t> field_ids_;
std::vector<uint32_t> gpu_indexes_;
bool need_cleanup_;
-2
View File
@@ -47,8 +47,6 @@ class RdciSubSystem {
std::vector<std::string> split_string(const std::string& s,
char delimiter) const;
void show_common_usage() const;
bool get_field_id_from_name(const std::string& name,
uint32_t& value) const; // NOLINT(runtime/references)
rdc_handle_t rdc_handle_;
std::string ip_port_;