AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rdc_field_t replaces uint32_t; centralize field data

Browse Source 
Make the RDC use the new rdc_field_t enum instead of uint32_t.
This will help prevent invalid field types from being passed in.

Also, centralize where data related to fields is kept. This will
reduce the number of places where changes are required each
time a new field is added.

Finally, cleaned up several cpplint issues.

Change-Id: I48e4512e18c164411d8b09ae3d4bed99fba359ec
This commit is contained in:
Chris Freehill
2020-07-24 19:40:48 -05:00
parent e6d910f67a
commit 5950ebadc4
43 changed files with 459 additions and 388 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/rdc_api_service.cc
+8 -7
View File
@@ -245,9 +245,9 @@ RdcAPIServiceImpl::~RdcAPIServiceImpl() {
}
rdc_field_grp_t field_group_id;
uint32_t field_ids[RDC_MAX_FIELD_IDS_PER_FIELD_GROUP];
rdc_field_t field_ids[RDC_MAX_FIELD_IDS_PER_FIELD_GROUP];
for (int i = 0; i < request->field_ids_size(); i++) {
field_ids[i] = request->field_ids(i);
field_ids[i] = static_cast<rdc_field_t>(request->field_ids(i));
}
rdc_status_t result = rdc_group_field_create(
rdc_handle_, request->field_ids_size() , &field_ids[0],
@@ -331,8 +331,9 @@ RdcAPIServiceImpl::~RdcAPIServiceImpl() {
}
rdc_field_value value;
rdc_status_t result = rdc_field_get_latest_value(
rdc_handle_, request->gpu_index(), request->field_id(), &value);
rdc_status_t result = rdc_field_get_latest_value(rdc_handle_,
request->gpu_index(), static_cast<rdc_field_t>(request->field_id()),
&value);
reply->set_status(result);
if (result != RDC_ST_OK) {
return ::grpc::Status::OK;
@@ -365,9 +366,9 @@ RdcAPIServiceImpl::~RdcAPIServiceImpl() {
rdc_field_value value;
uint64_t next_timestamp;
rdc_status_t result = rdc_field_get_value_since(
rdc_handle_, request->gpu_index(), request->field_id(),
request->since_time_stamp(), &next_timestamp, &value);
rdc_status_t result = rdc_field_get_value_since(rdc_handle_,
request->gpu_index(), static_cast<rdc_field_t>(request->field_id()),
request->since_time_stamp(), &next_timestamp, &value);
reply->set_status(result);
if (result != RDC_ST_OK) {
return ::grpc::Status::OK;