From 5b7549331fb90fb35ce5ca55e9de79f76a640074 Mon Sep 17 00:00:00 2001 From: Kent Russell Date: Fri, 23 Oct 2020 13:43:43 -0400 Subject: [PATCH] CMakeLists: Address-sanitizer fix and cleanup Move all the logic into 1 spot, and make sure -fsanitize=address is also passed to the library flags Change-Id: I7b60629d32df6436b5c7ad37997fe14ea48f5d72 [ROCm/ROCR-Runtime commit: 3d9f60d7fe3f918685e04a5e8b10ec5016810176] --- projects/rocr-runtime/CMakeLists.txt | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/projects/rocr-runtime/CMakeLists.txt b/projects/rocr-runtime/CMakeLists.txt index b397ead855..7970114c2d 100644 --- a/projects/rocr-runtime/CMakeLists.txt +++ b/projects/rocr-runtime/CMakeLists.txt @@ -92,20 +92,18 @@ endif () set ( HSAKMT_LINKER_SCRIPT "${CMAKE_CURRENT_SOURCE_DIR}/src/libhsakmt.ver" ) +## Linker Flags +## Add --enable-new-dtags to generate DT_RUNPATH +set (HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS} -Wl,--enable-new-dtags -Wl,--version-script=${HSAKMT_LINKER_SCRIPT} -Wl,-soname=${HSAKMT_COMPONENT}.so.${LIB_VERSION_MAJOR} -Wl,-z,nodelete -Wl,-no-undefined") + ## Address Sanitize Flag if ( ${ADDRESS_SANITIZER} ) set ( HSAKMT_C_FLAGS "${HSAKMT_C_FLAGS}" -fsanitize=address ) + set ( HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS}" -fsanitize=address ) message( STATUS "ADDRESS_SANITIZE: HSAKMT_C_FLAGS=: ${HSAKMT_C_FLAGS}" ) - set ( HSAKMT_LINK_FLAGS "-fsanitize=address" ) + message( STATUS "ADDRESS_SANITIZE: HSAKMT_LINK_FLAGS=: ${HSAKMT_LINK_FLAGS}" ) endif () -## Linker Flags -## Add --enable-new-dtags to generate DT_RUNPATH -set (HSAKMT_LINK_FLAGS "${HSAKMT_LINK_FLAGS} -Wl,--enable-new-dtags -Wl,--version-script=${HSAKMT_LINKER_SCRIPT} -Wl,-soname=${HSAKMT_COMPONENT}.so.${LIB_VERSION_MAJOR} -Wl,-z,nodelete -Wl,-no-undefined" ) - -# for debug -message( STATUS "ADDRESS_SANITIZE: HSAKMT_LINK_FLAGS=: ${HSAKMT_LINK_FLAGS}" ) - ## Source files set ( HSAKMT_SRC "src/debug.c" "src/events.c"