From 5d8bcd03dbf0fc32a52b1aa50272f78f63f2e045 Mon Sep 17 00:00:00 2001 From: Jeremy Newton Date: Tue, 16 Nov 2021 11:01:48 -0500 Subject: [PATCH] Use recommends for libdrm-amdgpu-amdgpu1 For the use of libdrm-amdgpu-amdgpu1 and libdrm-amdgpu, we should use recommends, as we want these packages installed with a strong dependency but avoid a strict dependency, since this is enhancement feature. Using the newer libdrm, which is build for amdgpu-dkms, is ideal since it will produce more correct marketing names, but should not be mandated due to two reasons: - A user may not want to install both libdrms on their system - The system might not have the newer libdrm available This patch only fixes the Ubuntu/debian package since recommends is not properly implemented for the RPM generator for CPACK. For now, "suggests" will have to do, since it's the closest option we have. I will investigate if we can get around this issue. Change-Id: I33a90c3ead235bbbe265238c026933688ea63fe3 Signed-off-by: Jeremy Newton [ROCm/ROCR-Runtime commit: 86c27a7af819fa354df9183897ae306261721bf5] --- projects/rocr-runtime/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/rocr-runtime/CMakeLists.txt b/projects/rocr-runtime/CMakeLists.txt index b63ff21e18..b656de7b57 100644 --- a/projects/rocr-runtime/CMakeLists.txt +++ b/projects/rocr-runtime/CMakeLists.txt @@ -351,7 +351,7 @@ set(CPACK_PACKAGE_VERSION "${PACKAGE_VERSION_STR}") # Setting devel package dependendent version set(CPACK_DEBIAN_PACKAGE_DEPENDS "libdrm-dev, rocm-core") -set(CPACK_DEBIAN_PACKAGE_SUGGESTS "libdrm-amdgpu-amdgpu1") +set(CPACK_DEBIAN_PACKAGE_RECOMMENDS "libdrm-amdgpu-amdgpu1") set(CPACK_DEBIAN_PACKAGE_REPLACES "hsakmt-roct") set(CPACK_RPM_PACKAGE_REQUIRES "libdrm-devel, rocm-core")