From 5dd2f94f7435321955b6f5e43021c694a2a3751d Mon Sep 17 00:00:00 2001 From: itrowbri Date: Fri, 27 Sep 2024 22:02:00 -0500 Subject: [PATCH] Updated validation of aborted-app test to use hipExtHostAlloc (#1103) * Updated validation of aborted-app test to use hipExtHostAlloc now that tracing for this command is supported * Updated CHANGELOG --- CHANGELOG.md | 1 + tests/rocprofv3/aborted-app/validate.py | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 85ff07ce04..60c379209b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -108,3 +108,4 @@ Full documentation for ROCprofiler-SDK is available at [Click Here](source/docs/ - Creation of subdirection when rocprofv3 `--output-file` contains a folder path - Fix misaligned stores (undefined behavior) for buffer records - Fix crash when only scratch reporting is enabled +- Fix aborted-app validation test to properly check for hipExtHostAlloc command now that it is supported diff --git a/tests/rocprofv3/aborted-app/validate.py b/tests/rocprofv3/aborted-app/validate.py index 1bcad43632..013e98f53f 100644 --- a/tests/rocprofv3/aborted-app/validate.py +++ b/tests/rocprofv3/aborted-app/validate.py @@ -99,11 +99,9 @@ def test_hip_api_trace_json(json_data): "hipGetLastError", ] ) - # TODO: When tracing support is added for hipExtHostAlloc, replace - # hipHostMalloc with hipExtHostAlloc instead of removing hipHostMalloc - # as is happening currently updated_expected_functions = [ - func for func in expected_functions if func != "hipHostMalloc" + func if func != "hipHostMalloc" else "hipExtHostAlloc" + for func in expected_functions ] assert functions == expected_functions or functions == updated_expected_functions