From 60a1e6dbc19fbc09c9a7f20b80846ca436a6f6cd Mon Sep 17 00:00:00 2001 From: "Sang, Tao" Date: Tue, 8 Apr 2025 20:30:06 -0400 Subject: [PATCH] SWDEV-523824 - Fix data validation issue of rocFFT (#154) Fix data validation issue of rocFFT when dynamic queue on. ReleaseHwQueue() can be called only when no command in HostQueue. The checking condition need be protected by lock. [ROCm/clr commit: 18d191fd1d0616cf1d22947d6638e4615e2e4c3e] --- projects/clr/rocclr/platform/commandqueue.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/projects/clr/rocclr/platform/commandqueue.cpp b/projects/clr/rocclr/platform/commandqueue.cpp index e575a5c649..f9df497add 100644 --- a/projects/clr/rocclr/platform/commandqueue.cpp +++ b/projects/clr/rocclr/platform/commandqueue.cpp @@ -192,12 +192,10 @@ void HostQueue::finish(bool cpu_wait) { device_.removeFromActiveQueues(this); lastEnqueueCommand_->release(); lastEnqueueCommand_ = nullptr; + vdev()->ReleaseHwQueue(); // we can only release HwQueue when no commmand in quque. } } } - // Release HW queue to the pool for dynamic management if enabled - vdev()->ReleaseHwQueue(); - command->release(); ClPrint(LOG_DEBUG, LOG_CMD, "All commands finished for host queue : %p", this); }