AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-296922 : Incorrect rounding due to integer division in rocprofiler metrics

Browse Source 
Changed derived metrics to double from int64.
Fixed standalone test due to int64 to float change
Fixed intercept test due to int64 to float change.

Change-Id: I49631c187406ae9dd94a869b3bb13772012e8cdf


[ROCm/rocprofiler commit: f9017cbdc5]
This commit is contained in:
Chun Yang
2021-08-11 19:55:31 -07:00
parent d6a648e396
commit 62a76c8ebb
6 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocprofiler/test/app/intercept_test.cpp
+3
View File
@@ -124,6 +124,9 @@ void dump_context_entry(context_entry_t* entry, rocprofiler_feature_t* features,
case ROCPROFILER_DATA_KIND_INT64:
fprintf(stdout, "= (%lu)\n", p->data.result_int64);
break;
case ROCPROFILER_DATA_KIND_DOUBLE:
fprintf(stdout, "= (%lf)\n", p->data.result_double);
break;
default:
fprintf(stderr, "Undefined data kind(%u)\n", p->data.kind);
abort();
projects/rocprofiler/test/app/standalone_test.cpp
+3
View File
@@ -78,6 +78,9 @@ void print_features(rocprofiler_feature_t* feature, uint32_t feature_count) {
case ROCPROFILER_DATA_KIND_INT64:
std::cout << std::dec << " result64 (" << p->data.result_int64 << ")" << std::endl;
break;
case ROCPROFILER_DATA_KIND_DOUBLE:
std::cout << " result64 (" << p->data.result_double << ")" << std::endl;
break;
case ROCPROFILER_DATA_KIND_BYTES: {
const char* ptr = reinterpret_cast<const char*>(p->data.result_bytes.ptr);
uint64_t size = 0;
projects/rocprofiler/test/tool/tool.cpp
+6 -2
View File
@@ -351,6 +351,9 @@ void output_results(const context_entry_t* entry, const char* label) {
case ROCPROFILER_DATA_KIND_INT64:
fprintf(file, "(%lu)\n", p->data.result_int64);
break;
case ROCPROFILER_DATA_KIND_DOUBLE:
fprintf(file, "(%.10lf)\n", p->data.result_double);
break;
default:
fprintf(stderr, "RPL-tool: undefined data kind(%u)\n", p->data.kind);
abort();
@@ -358,12 +361,13 @@ void output_results(const context_entry_t* entry, const char* label) {
}
}
// Output group intermeadate profiling results, created internally for complex metrics
// Output group intermediate profiling results, created internally for complex metrics
void output_group(const context_entry_t* entry, const char* label) {
const rocprofiler_group_t* group = &(entry->group);
context_entry_t group_entry = *entry;
for (unsigned i = 0; i < group->feature_count; ++i) {
if (group->features[i]->data.kind == ROCPROFILER_DATA_KIND_INT64) {
if (group->features[i]->data.kind == ROCPROFILER_DATA_KIND_INT64 ||
group->features[i]->data.kind == ROCPROFILER_DATA_KIND_DOUBLE) {
group_entry.features = group->features[i];
group_entry.feature_count = 1;
output_results(&group_entry, label);