From 63eb3948beefcb41c6d28470bb5811c667896de1 Mon Sep 17 00:00:00 2001 From: Oak Zeng Date: Mon, 9 Sep 2019 11:02:56 -0500 Subject: [PATCH] More parameter check in HsaMemoryBuffer constructor if parameter "zero" is set, check buffer host access. Change-Id: I9893062726fc240777405167a638cbea18fdf559 Signed-off-by: Oak Zeng --- tests/kfdtest/src/KFDLocalMemoryTest.cpp | 2 +- tests/kfdtest/src/KFDTestUtil.cpp | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/kfdtest/src/KFDLocalMemoryTest.cpp b/tests/kfdtest/src/KFDLocalMemoryTest.cpp index 0af52e9d8e..4c86594ab9 100644 --- a/tests/kfdtest/src/KFDLocalMemoryTest.cpp +++ b/tests/kfdtest/src/KFDLocalMemoryTest.cpp @@ -128,7 +128,7 @@ TEST_F(KFDLocalMemoryTest, VerifyContentsAfterUnmapAndMap) { HsaMemoryBuffer isaBuffer(PAGE_SIZE, defaultGPUNode); HsaMemoryBuffer SysBufferA(BufferSize, defaultGPUNode, false); HsaMemoryBuffer SysBufferB(BufferSize, defaultGPUNode, true); - HsaMemoryBuffer LocalBuffer(BufferSize, defaultGPUNode, true, true); + HsaMemoryBuffer LocalBuffer(BufferSize, defaultGPUNode, false, true); SysBufferA.Fill(0x01010101); diff --git a/tests/kfdtest/src/KFDTestUtil.cpp b/tests/kfdtest/src/KFDTestUtil.cpp index d1e398fa1b..9383c31002 100644 --- a/tests/kfdtest/src/KFDTestUtil.cpp +++ b/tests/kfdtest/src/KFDTestUtil.cpp @@ -197,6 +197,9 @@ HsaMemoryBuffer::HsaMemoryBuffer(HSAuint64 size, unsigned int node, bool zero, b if (isReadOnly) m_Flags.ui32.ReadOnly = 1; + if (zero) + EXPECT_EQ(m_Flags.ui32.HostAccess, 1); + EXPECT_SUCCESS(hsaKmtAllocMemory(m_Node, m_Size, m_Flags, &m_pBuf)); if (is_dgpu()) { if (map_specific_gpu)