P4 to Git Change 1567428 by gandryey@gera-w8 on 2018/06/12 18:39:23

SWDEV-79445 - OCL generic changes and code clean-up
	- Optimize setup of kernel arguments. Stage 2.
	- Add HW ABI support in the abstraction layer
	- Remove arguments parsing loop from the kernel launch. Memory processing will be responsible for dependency tracking and  patching of arguments.

	http://ocltc.amd.com/reviews/r/15122/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#221 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#307 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpukernel.cpp#325 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#53 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.hpp#9 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#107 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#53 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rockernel.cpp#36 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/kernel.cpp#30 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/kernel.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/program.cpp#95 edit


[ROCm/clr commit: 1be400ff01]

projects/clr/rocclr/runtime/device/gpu/gpukernel.cpp

@@ -752,7 +752,8 @@ bool NullKernel::create(const std::string& code, const std::string& metadata,
   workGroupInfo_.usedStackSize_ = calFuncInfo.stackSizeUsed;
 
   device::Kernel::parameters_t params;
-  if (!createSignature(params)) {
+  device::Kernel::parameters_t hiddenParams;
+  if (!createSignature(params, hiddenParams, amd::KernelSignature::ABIVersion_0)) {
     return false;
   }
 
@@ -1337,7 +1338,8 @@ bool Kernel::initParameters() {
     workGroupInfo_.localMemSize_ = hwLocalSize_;
   }
 
-  if (!createSignature(params)) {
+  device::Kernel::parameters_t hiddenParams;
+  if (!createSignature(params, hiddenParams, amd::KernelSignature::ABIVersion_0)) {
     return false;
   }
 
@@ -3017,7 +3019,8 @@ void HSAILKernel::initArgList(const aclArgData* aclArg) {
     }
   }
 
-  createSignature(params);
+  device::Kernel::parameters_t hiddenParams;
+  createSignature(params, hiddenParams, amd::KernelSignature::ABIVersion_0);
 }
 
 void HSAILKernel::initHsailArgs(const aclArgData* aclArg) {