SWDEV-279486 - Fix hipMemcpyPeer/hipMemcpy APIs
Addresses the scenarios when the size passed is more than the allocated size and when the deviceid is invalid Change-Id: I6c9b62639096f655ffb61976905b1ce8c5f51ee7 Change-Id: I8a0d660924a8e2300c517aba6f9088626b8f6ef5
Šī revīzija ir iekļauta:
@@ -212,6 +212,12 @@ hipError_t ihipMemcpy(void* dst, const void* src, size_t sizeBytes, hipMemcpyKin
|
||||
amd::Memory *srcMemory = getMemoryObject(src, sOffset);
|
||||
size_t dOffset = 0;
|
||||
amd::Memory *dstMemory = getMemoryObject(dst, dOffset);
|
||||
// Return error if sizeBytes passed to memcpy is more than the actual size allocated
|
||||
if ((dstMemory && sizeBytes > (dstMemory->getSize() - dOffset)) ||
|
||||
(srcMemory && sizeBytes > (srcMemory->getSize() - sOffset))) {
|
||||
return hipErrorInvalidValue;
|
||||
}
|
||||
|
||||
amd::Device* queueDevice = &queue.device();
|
||||
if ((srcMemory == nullptr) && (dstMemory == nullptr)) {
|
||||
if ((kind == hipMemcpyHostToHost) || (kind == hipMemcpyDefault)) {
|
||||
|
||||
@@ -215,6 +215,12 @@ hipError_t hipMemcpyPeer(void* dst, int dstDevice, const void* src, int srcDevic
|
||||
size_t sizeBytes) {
|
||||
HIP_INIT_API(hipMemcpyPeer, dst, dstDevice, src, srcDevice, sizeBytes);
|
||||
|
||||
if (srcDevice >= static_cast<int>(g_devices.size()) ||
|
||||
dstDevice >= static_cast<int>(g_devices.size()) ||
|
||||
srcDevice < 0 || dstDevice < 0) {
|
||||
HIP_RETURN(hipErrorInvalidDevice);
|
||||
}
|
||||
|
||||
HIP_RETURN(hipMemcpy(dst, src, sizeBytes, hipMemcpyDeviceToDevice));
|
||||
}
|
||||
|
||||
@@ -222,6 +228,12 @@ hipError_t hipMemcpyPeerAsync(void* dst, int dstDevice, const void* src, int src
|
||||
size_t sizeBytes, hipStream_t stream) {
|
||||
HIP_INIT_API(hipMemcpyPeerAsync, dst, dstDevice, src, srcDevice, sizeBytes, stream);
|
||||
|
||||
if (srcDevice >= static_cast<int>(g_devices.size()) ||
|
||||
dstDevice >= static_cast<int>(g_devices.size()) ||
|
||||
srcDevice < 0 || dstDevice < 0) {
|
||||
HIP_RETURN(hipErrorInvalidDevice);
|
||||
}
|
||||
|
||||
HIP_RETURN(hipMemcpyAsync(dst, src, sizeBytes, hipMemcpyDeviceToDevice, stream));
|
||||
}
|
||||
|
||||
|
||||
Atsaukties uz šo jaunā problēmā
Block a user