From 6975697b5650218edd04126cb7ba5cbd08ff58e7 Mon Sep 17 00:00:00 2001
From: gabrpham <Gabriel.Pham@amd.com>
Date: Mon, 5 Aug 2024 13:05:12 -0500
Subject: [PATCH] Fixed cli issue with empty cpu/core parameter

Change-Id: Id0fee74357a56baaec59ca5359eb00a65cfd6185
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>


[ROCm/amdsmi commit: 01430412626ef59484656c08cbf7623ee3e18a57]
---
 projects/amdsmi/CHANGELOG.md                | 20 ++++++++++++++++++++
 projects/amdsmi/amdsmi_cli/amdsmi_parser.py |  3 +++
 2 files changed, 23 insertions(+)

diff --git a/projects/amdsmi/CHANGELOG.md b/projects/amdsmi/CHANGELOG.md
index da6bd5d8a6..95dccc8593 100644
--- a/projects/amdsmi/CHANGELOG.md
+++ b/projects/amdsmi/CHANGELOG.md
@@ -4,6 +4,26 @@ Full documentation for amd_smi_lib is available at [https://rocm.docs.amd.com/pr
 
 ***All information listed below is for reference and subject to change.***
 
+## amd_smi_lib for ROCm 6.2.1
+
+### Additions
+
+- N/A
+
+### Optimizations
+
+- N/A
+
+### Fixes
+
+- **Fixed TypeError in `amd-smi process -G`**.  
+
+- **Updated CLI error strings to handle empty and invalid GPU/CPU inputs**.  
+
+### Known Issues
+
+- N/A
+
 ## amd_smi_lib for ROCm 6.2.0
 
 ### Additions
diff --git a/projects/amdsmi/amdsmi_cli/amdsmi_parser.py b/projects/amdsmi/amdsmi_cli/amdsmi_parser.py
index 4f97ad8f7c..77e4db1831 100644
--- a/projects/amdsmi/amdsmi_cli/amdsmi_parser.py
+++ b/projects/amdsmi/amdsmi_cli/amdsmi_parser.py
@@ -375,6 +375,9 @@ class AMDSMIParser(argparse.ArgumentParser):
 
 
     def _validate_cpu_core(self, value):
+        if value == '':
+            outputformat = self.helpers.get_output_format()
+            raise amdsmi_cli_exceptions.AmdSmiMissingParameterValueException(value, outputformat)
         if isinstance(value, str):
             if value.lower() == "all":
                 return value